Skip to content

Cache pre-commit workflow #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

Cache pre-commit workflow #3863

merged 1 commit into from
Nov 5, 2020

Conversation

dhruvmanila
Copy link
Member

Describe your change:

Add the ability to cache pre-commit workflow to be reused later.

  • Improve workflow

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.

@dhruvmanila dhruvmanila requested a review from cclauss as a code owner November 5, 2020 06:12
@dhruvmanila dhruvmanila added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 5, 2020
cclauss
cclauss requested changes Nov 5, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM Do you have a sense for how much time this saves us?

@dhruvmanila
Copy link
Member Author

dhruvmanila commented Nov 5, 2020 •
edited
Loading

This will cache the pip and pre-commit downloads. This will also cache all the environments pre-commit initializes at the start of each run which includes black, flake8, isort, and the rest of them.

I think approximately a minute or so in each run.

What is RSLGTM?

@cclauss
Copy link
Member

cclauss commented Nov 5, 2020

https://chromium.googlesource.com/chromiumos/docs/+/master/glossary.md

@cclauss cclauss merged commit fdba34f into TheAlgorithms:master Nov 5, 2020
@cclauss
Copy link
Member

cclauss commented Nov 5, 2020

1m17s --> 41s

@dhruvmanila dhruvmanila deleted the cache-workflow branch November 5, 2020 16:20
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@dhruvmanila @stokhos
Cache pre-commit workflow (TheAlgorithms#3863)
ebf9eea
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@dhruvmanila @peRFectBeliever
Cache pre-commit workflow (TheAlgorithms#3863)
f81f3b0
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila
Cache pre-commit workflow (TheAlgorithms#3863)
70c7a68
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@dhruvmanila @shermanhui
Cache pre-commit workflow (TheAlgorithms#3863)
89f341c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @cclauss