Skip to content

Update caesar_cipher.py #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2020
Merged

Update caesar_cipher.py #3860

merged 2 commits into from
Dec 10, 2020

Conversation

DjaouadNM
Copy link
Contributor

@DjaouadNM DjaouadNM commented Nov 2, 2020 •
edited
Loading

improved for conciseness and readability

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Improved existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@DjaouadNM
Update caesar_cipher.py
b3454a9 
improved for conciseness and readability
@mrmaxguns
Copy link
Member

This seems like the easiest and most pythonic way to do brute force.

@mrmaxguns
Copy link
Member

@cclauss Could you review this PR?

@amaank404
Copy link
Contributor

@dhruvmanila, this seems good to go

@dhruvmanila
Copy link
Member

@algorithms-keeper review-all

@ghost ghost added enhancement This PR modified some existing files require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Dec 10, 2020
@dhruvmanila
Copy link
Member

@algorithms-keeper review-all

@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed require type hints https://docs.python.org/3/library/typing.html require tests Tests [doctest/unittest/pytest] are required labels Dec 10, 2020
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Dec 10, 2020
@dhruvmanila dhruvmanila merged commit 110a740 into TheAlgorithms:master Dec 10, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@DjaouadNM @dhruvmanila @stokhos
Update ciphers/caesar_cipher.py with type hints (TheAlgorithms#3860)
ac64871 
* Update caesar_cipher.py

improved for conciseness and readability

* Add type hints

Co-authored-by: Dhruv Manilawala <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@DjaouadNM @dhruvmanila @peRFectBeliever
Update ciphers/caesar_cipher.py with type hints (TheAlgorithms#3860)
fa75ee4 
* Update caesar_cipher.py

improved for conciseness and readability

* Add type hints

Co-authored-by: Dhruv Manilawala <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@DjaouadNM @dhruvmanila
Update ciphers/caesar_cipher.py with type hints (TheAlgorithms#3860)
932a01b 
* Update caesar_cipher.py

improved for conciseness and readability

* Add type hints

Co-authored-by: Dhruv Manilawala <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@DjaouadNM @dhruvmanila @shermanhui
Update ciphers/caesar_cipher.py with type hints (TheAlgorithms#3860)
b67d42e 
* Update caesar_cipher.py

improved for conciseness and readability

* Add type hints

Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmaxguns mrmaxguns mrmaxguns left review comments

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DjaouadNM @mrmaxguns @amaank404 @dhruvmanila