Skip to content

Created greedy_coin_change.py file #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 20, 2021
Merged

Created greedy_coin_change.py file #3805

merged 12 commits into from
Mar 20, 2021

Conversation

DevanshiPatel18
Copy link
Contributor

added the file in greedy_methods folder to implement the same method

Created the said file to implement the greedy coin change problem.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@DevanshiPatel18
Hacktoberfest: Created greedy_coin_change.py file
205c502 
added the file in greedy_methods folder to implement the same method
@DevanshiPatel18 DevanshiPatel18 changed the title Hacktoberfest: Created greedy_coin_change.py file Created greedy_coin_change.py file Oct 28, 2020
@DevanshiPatel18
Copy link
Contributor Author

Can someone review my PR?

mrmaxguns
mrmaxguns suggested changes Nov 5, 2020
View reviewed changes
Copy link
Member

@mrmaxguns mrmaxguns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my review. Thanks for contributing to open source!

@amaank404
Copy link
Contributor

@DevanshiPatel18, just to confirm are you there? This PR might get closed due to inactivity

@DevanshiPatel18
Add files via upload
4bdc334 
Altered the code according to the changes that were requested.
@ghost ghost added the require tests Tests [doctest/unittest/pytest] are required label Nov 27, 2020
@DevanshiPatel18
Copy link
Contributor Author

Here is my review. Thanks for contributing to open source!

Hi,
I made the changes that you requested. Kindly verify if they are proper.

Thanks.

DevanshiPatel18
DevanshiPatel18 commented Nov 27, 2020
View reviewed changes
Copy link
Contributor Author

@DevanshiPatel18 DevanshiPatel18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are effective in the new code.Thanks.

amaank404
amaank404 suggested changes Nov 27, 2020
View reviewed changes
@DevanshiPatel18
Added doctests.
a5ef4f3 
doctests added to the function find_minimum_change.
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed require tests Tests [doctest/unittest/pytest] are required labels Nov 27, 2020
@amaank404
Copy link
Contributor

Also we are planning to remove the directory greedy, possibly move it any other categories

@amaank404
Copy link
Contributor

Also we are planning to remove the directory greedy, possibly move it any other categories

You should do it, please.

pj46280
pj46280 reviewed Nov 29, 2020
View reviewed changes
Copy link

@pj46280 pj46280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested other few test cases by myself it worked fine with me.

@DevanshiPatel18
Copy link
Contributor Author

Hi,

Also we are planning to remove the directory greedy, possibly move it any other categories

You should do it, please.

The greedy directory is removed so where should I move this file to?

@amaank404
Copy link
Contributor

Its upto your choice, i would recommend use maths directory

@stale
Copy link

stale bot commented Dec 29, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Dec 29, 2020
@gabbygitty007
Copy link

gabbygitty007 commented Dec 29, 2020 via email

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Dec 29, 2020
@amaank404
Copy link
Contributor

I'm active sir
…
On Thu, Nov 26, 2020, 6:06 PM xcodz-dot, @.***> wrote: @DevanshiPatel18 https://github.com/DevanshiPatel18, just to confirm are you there? This PR might get closed due to inactivity — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3805 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQOBVQP4RUZ6OUY5ID7KSBLSR2KLFANCNFSM4TCC5E6A .

Hello you have mistaken on this email. The email was sent long while ago and was mentioned for @DevanshiPatel18

@stale
Copy link

stale bot commented Jan 31, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Jan 31, 2021
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Feb 3, 2021
@mrmaxguns
Copy link
Member

All necessary changes have been made, I believe that this pull request is ready to be merged 💯, although it must be approved by a user with write access for that to happen.

amaank404
amaank404 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@amaank404 amaank404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

cc: @cclauss @dhruvmanila

@stale
Copy link

stale bot commented Mar 19, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Mar 19, 2021
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Mar 20, 2021
@ghost ghost added the merge conflicts Open a new PR or rebase on the latest commit label Mar 20, 2021
@ghost ghost removed the merge conflicts Open a new PR or rebase on the latest commit label Mar 20, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Mar 20, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Mar 20, 2021
@dhruvmanila dhruvmanila merged commit dd757dc into TheAlgorithms:master Mar 20, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 20, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@DevanshiPatel18 @dhruvmanila @peRFectBeliever
feat: Add greedy_coin_change.py algorithm (TheAlgorithms#3805)
7bd733b 
* Hacktoberfest: Add greedy_coin_change.py file 

added the file in greedy_methods folder to implement the same method

Altered the code according to the changes that were requested.

* Added doctests.

doctests added to the function find_minimum_change.

* Added Greedy change file in Maths folder.

* updating DIRECTORY.md

* Deleted Greedy Method Folder

* updating DIRECTORY.md

* Update greedy_coin_change.py

* fix: black formatting issues

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv Manilawala <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@DevanshiPatel18 @dhruvmanila
feat: Add greedy_coin_change.py algorithm (TheAlgorithms#3805)
4e70c92 
* Hacktoberfest: Add greedy_coin_change.py file 

added the file in greedy_methods folder to implement the same method

Altered the code according to the changes that were requested.

* Added doctests.

doctests added to the function find_minimum_change.

* Added Greedy change file in Maths folder.

* updating DIRECTORY.md

* Deleted Greedy Method Folder

* updating DIRECTORY.md

* Update greedy_coin_change.py

* fix: black formatting issues

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv Manilawala <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@DevanshiPatel18 @dhruvmanila @shermanhui
feat: Add greedy_coin_change.py algorithm (TheAlgorithms#3805)
8d946ed 
* Hacktoberfest: Add greedy_coin_change.py file 

added the file in greedy_methods folder to implement the same method

Altered the code according to the changes that were requested.

* Added doctests.

doctests added to the function find_minimum_change.

* Added Greedy change file in Maths folder.

* updating DIRECTORY.md

* Deleted Greedy Method Folder

* updating DIRECTORY.md

* Update greedy_coin_change.py

* fix: black formatting issues

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pj46280 pj46280 pj46280 left review comments

@mrmaxguns mrmaxguns mrmaxguns approved these changes

@amaank404 amaank404 amaank404 approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DevanshiPatel18 @amaank404 @gabbygitty007 @mrmaxguns @pj46280 @dhruvmanila