Skip to content

HACKTOBERFEST - Added solution to Euler 64. #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2020

Conversation

sudoShikhar
Copy link
Contributor

@sudoShikhar sudoShikhar commented Oct 24, 2020

This PR is for Hacktoberfest. #Hacktoberfest
Added Python solution to Project Euler Problem 64.

Describe your change:

Added my solution to the Project Euler Problem 64.
Added a folder problem_064.
Added init.py file.
Added sol1.py file.
Fixes: #3705

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Added Python solution to Project Euler Problem 64.
Added a folder problem_064.
Added __init__.py file.
Added sol1.py file.
Made formatting changes as mentioned by pre-commit
@sudoShikhar
Copy link
Contributor Author

Requesting @dhruvmanila and @Kush1101 to review the commit.

Cheers!

@sudoShikhar
Copy link
Contributor Author

@dhruvmanila @Kush1101 Anyone around?
Please could you review the PR?

@sudoShikhar sudoShikhar changed the title Added solution to Euler 64. Hacktoberfest - Added solution to Euler 64. Oct 29, 2020
@sudoShikhar
Copy link
Contributor Author

@cclauss
@dhruvmanila
@Kush1101

Guys please do the needful!

@sudoShikhar sudoShikhar changed the title Hacktoberfest - Added solution to Euler 64. HACKTOBERFEST - Added solution to Euler 64. Oct 31, 2020
@amaank404
Copy link
Contributor

looks good, sorry for late response (You know the stats, right.)

@cclauss @dhruvmanila @Kush1101 @poyea @ruppysuppy, Possibly anyone check this out

@sudoShikhar
Copy link
Contributor Author

looks good, sorry for late response (You know the stats, right.)

@cclauss @dhruvmanila @Kush1101 @poyea @ruppysuppy, Possibly anyone check this out

Yeah man! You guys have been flooded with PRs.
I'd love to help up any way posssible!!!!

Minor changes to variable naming and function calling as mentioned by @ruppysuppy
@cclauss
Copy link
Member

cclauss commented Nov 2, 2020

Please revert the last change. It removes the end user's ability to experiment with different inputs.

@sudoShikhar
Copy link
Contributor Author

Please revert the last change. It removes the end user's ability to experiment with different inputs.

On it.

Changes to function call as mentioned by @cclauss
@ruppysuppy ruppysuppy merged commit 29d0fbb into TheAlgorithms:master Nov 3, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added solution to Euler 64.

Added Python solution to Project Euler Problem 64.
Added a folder problem_064.
Added __init__.py file.
Added sol1.py file.

* Update sol1.py

Made formatting changes as mentioned by pre-commit

* Update sol1.py

Minor changes to variable naming and function calling as mentioned by @ruppysuppy

* Update sol1.py

Changes to function call as mentioned by @cclauss
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Added solution to Euler 64.

Added Python solution to Project Euler Problem 64.
Added a folder problem_064.
Added __init__.py file.
Added sol1.py file.

* Update sol1.py

Made formatting changes as mentioned by pre-commit

* Update sol1.py

Minor changes to variable naming and function calling as mentioned by @ruppysuppy

* Update sol1.py

Changes to function call as mentioned by @cclauss
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added solution to Euler 64.

Added Python solution to Project Euler Problem 64.
Added a folder problem_064.
Added __init__.py file.
Added sol1.py file.

* Update sol1.py

Made formatting changes as mentioned by pre-commit

* Update sol1.py

Minor changes to variable naming and function calling as mentioned by @ruppysuppy

* Update sol1.py

Changes to function call as mentioned by @cclauss
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Added solution to Euler 64.

Added Python solution to Project Euler Problem 64.
Added a folder problem_064.
Added __init__.py file.
Added sol1.py file.

* Update sol1.py

Made formatting changes as mentioned by pre-commit

* Update sol1.py

Minor changes to variable naming and function calling as mentioned by @ruppysuppy

* Update sol1.py

Changes to function call as mentioned by @cclauss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HACKTOBERFEST - Add Solution to Project Euler Question 64.
4 participants