-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
A divide and conquer method in finding the maximum difference pair #3692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dhruvmanila @poyea @Kush1101, Please check this (Ready to be merged) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a main function:
if __name__ == "__main__":
import doctest
doctest.testmod()
@poyea check this out (Changes made) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
See if this is sufficient for merge, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the value the function returns is a pair of 2 array values, right? You may modify the comment if that's the case. Thank you for your pull request!🤩
The return is a 2-tuple of integers, actually, which is the comment. |
Yeah I misread something. |
TheAlgorithms#3692) * A divide and conquer method in finding the maximum difference pair * fix formatting issues * fix formatting issues * add doctest runner
TheAlgorithms#3692) * A divide and conquer method in finding the maximum difference pair * fix formatting issues * fix formatting issues * add doctest runner
TheAlgorithms#3692) * A divide and conquer method in finding the maximum difference pair * fix formatting issues * fix formatting issues * add doctest runner
TheAlgorithms#3692) * A divide and conquer method in finding the maximum difference pair * fix formatting issues * fix formatting issues * add doctest runner
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}
.