Skip to content

A divide and conquer method in finding the maximum difference pair #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2020

Conversation

choyiny
Copy link
Contributor

@choyiny choyiny commented Oct 24, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@amaank404
Copy link
Contributor

@dhruvmanila @poyea @Kush1101, Please check this (Ready to be merged)

Copy link
Contributor

@amaank404 amaank404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work

Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a main function:

if __name__ == "__main__":
    import doctest

    doctest.testmod()

@poyea poyea self-assigned this Oct 24, 2020
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 24, 2020
@amaank404
Copy link
Contributor

@poyea check this out (Changes made)

@stale
Copy link

stale bot commented Nov 24, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 24, 2020
@choyiny
Copy link
Contributor Author

choyiny commented Nov 24, 2020

See if this is sufficient for merge, thanks.

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Nov 24, 2020
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 24, 2020
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the value the function returns is a pair of 2 array values, right? You may modify the comment if that's the case. Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 24, 2020
@choyiny
Copy link
Contributor Author

choyiny commented Nov 25, 2020

I think the value the function returns is a pair of 2 array values, right? You may modify the comment if that's the case. Thank you for your pull request!🤩

The return is a 2-tuple of integers, actually, which is the comment.

@poyea
Copy link
Member

poyea commented Nov 25, 2020

I think the value the function returns is a pair of 2 array values, right? You may modify the comment if that's the case. Thank you for your pull request!🤩

The return is a 2-tuple of integers, actually, which is the comment.

Yeah I misread something.

@poyea poyea merged commit 287bf26 into TheAlgorithms:master Nov 25, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
TheAlgorithms#3692)

* A divide and conquer method in finding the maximum difference pair

* fix formatting issues

* fix formatting issues

* add doctest runner
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
TheAlgorithms#3692)

* A divide and conquer method in finding the maximum difference pair

* fix formatting issues

* fix formatting issues

* add doctest runner
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
TheAlgorithms#3692)

* A divide and conquer method in finding the maximum difference pair

* fix formatting issues

* fix formatting issues

* add doctest runner
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
TheAlgorithms#3692)

* A divide and conquer method in finding the maximum difference pair

* fix formatting issues

* fix formatting issues

* add doctest runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants