Skip to content

Peak of unimodal list DNC algorithm #3691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2020
Merged

Peak of unimodal list DNC algorithm #3691

merged 4 commits into from
Nov 11, 2020

Conversation

choyiny
Copy link
Contributor

@choyiny choyiny commented Oct 24, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@choyiny
Copy link
Contributor Author

choyiny commented Oct 28, 2020

Looking to get a hacktoberfest-accepted tag if possible. @poyea

@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 29, 2020
@poyea poyea self-assigned this Oct 29, 2020
@amaank404
Copy link
Contributor

run pip install black
run black peak.py and then reupload peak.py

poyea
poyea approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea merged commit eb5a951 into TheAlgorithms:master Nov 11, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@choyiny @stokhos
Peak of unimodal list DNC algorithm (TheAlgorithms#3691)
1bd8d44 
* Peak of unimodal list DNC algorithm

* fix black formatting issues

* add doctest testing

* make file black compliant
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@choyiny @peRFectBeliever
Peak of unimodal list DNC algorithm (TheAlgorithms#3691)
a61c1af 
* Peak of unimodal list DNC algorithm

* fix black formatting issues

* add doctest testing

* make file black compliant
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@choyiny
Peak of unimodal list DNC algorithm (TheAlgorithms#3691)
94ea753 
* Peak of unimodal list DNC algorithm

* fix black formatting issues

* add doctest testing

* make file black compliant
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@choyiny @shermanhui
Peak of unimodal list DNC algorithm (TheAlgorithms#3691)
bb2a479 
* Peak of unimodal list DNC algorithm

* fix black formatting issues

* add doctest testing

* make file black compliant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaank404 amaank404 amaank404 left review comments

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@choyiny @amaank404 @poyea