Skip to content

Update doubly linked list #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Update doubly linked list #3619

merged 4 commits into from
Oct 21, 2020

Conversation

realDuYuanChao
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are really not enough tests here. This submission deletes a lot of tests which is going in the wrong direction. We need more tests, not fewer. It is OK to create a separate test file as long as pytest finds it via test discovery but it is too difficult to spot bugs without tests.

Please move the definition of Node before LinkedList.
The name of the file and the name of the main class should match so perhaps the class should be DoublyLinkedList.

add more test
@cclauss
Copy link
Member

cclauss commented Oct 21, 2020

Please add a doctest on .__iter__()...

        >>> linked_list = DoublyLinkedList()
        >>> linked_list.insert_at_head('b')
        >>> linked_list.insert_at_head('a')
        >>> linked_list.insert_at_tail('c')
        >>> tuple(linked_list)
        ('a', 'b', 'c')

@realDuYuanChao
Copy link
Member Author

@cclauss Done.

@cclauss
Copy link
Member

cclauss commented Oct 21, 2020

OPTIONAL: Create Node as a Python dataclass which will automatically create .__init__() and .__str__()...

% python3

>>> from __future__ import annotations
>>> from dataclasses import dataclass
>>> from typing import Any, Optional
>>> @dataclass
... class Node:
...     data: Any
...     prev: Optional[Node] = None
...     next: Optional[Node] = None
...
>>> Node("Data")
Node(data='Data', prev=None, next=None)

@realDuYuanChao
Copy link
Member Author

OPTIONAL: Create Node as a Python dataclass which will automatically create .__init__() and .__str__()...

% python3

>>> from __future__ import annotations
>>> from dataclasses import dataclass
>>> from typing import Any, Optional
>>> @dataclass
... class Node:
...     data: Any
...     prev: Optional[Node] = None
...     next: Optional[Node] = None
...
>>> Node("Data")
Node(data='Data', prev=None, next=None)

I'am not familiar with this. I think current version is friendly to beginner. BTW. this PR can be merged ? :)

@cclauss
Copy link
Member

cclauss commented Oct 21, 2020

More worried about merging than learning?

@realDuYuanChao
Copy link
Member Author

More worried about merging than learning?

I will study in a few days. 👍 :)

@realDuYuanChao realDuYuanChao merged commit 5e64260 into TheAlgorithms:master Oct 21, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* update doubly linked list

* reformat code
add more test

* add test to iter

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* update doubly linked list

* reformat code
add more test

* add test to iter

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* update doubly linked list

* reformat code
add more test

* add test to iter

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* update doubly linked list

* reformat code
add more test

* add test to iter

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants