Skip to content

Made small improvements and shortened prime_check.py #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2020
Merged

Made small improvements and shortened prime_check.py #3454

merged 3 commits into from
Oct 23, 2020

Conversation

Rolv-Apneseth
Copy link
Contributor

Describe your change:

Made small improvements and shortened prime_check.py
Shortened overall code and changed some of the comments/docstrings

For issue #3453

@Rolv-Apneseth
Copy link
Contributor Author

Ok Not sure why that check failed, when I run prime_check(1) on my code it returns False as it should. However I'm not really sure how these tests work. Can somebody help?

@Rolv-Apneseth
Copy link
Contributor Author

Pre-commit check is not failing on self.assertFalse(prime_check(2 * 3)) but when run locally, all tests succeed, and running prime_check(2 * 3) returns False as it should so I'm confused

@Rolv-Apneseth Rolv-Apneseth mentioned this pull request Oct 21, 2020
Closed
@poyea
Copy link
Member

poyea commented Oct 22, 2020

Please run black . for your code. https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md

@poyea
Copy link
Member

poyea commented Oct 22, 2020

I think you can enable the github actions in your setting of the fork too.

@Rolv-Apneseth
Copy link
Contributor Author

Rolv-Apneseth commented Oct 22, 2020 •
edited
Loading

@popyea of course, thank you for the help!

poyea
poyea approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea merged commit 04fae4d into TheAlgorithms:master Oct 23, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Rolv-Apneseth @stokhos
Improved and shortened prime_check.py (TheAlgorithms#3454)
db8d62f 
* Made small improvements and shortened prime_check.py

* improved descriptions on tests in prime_check.py

* Ran black and isort
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@Rolv-Apneseth @peRFectBeliever
Improved and shortened prime_check.py (TheAlgorithms#3454)
444f792 
* Made small improvements and shortened prime_check.py

* improved descriptions on tests in prime_check.py

* Ran black and isort
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Rolv-Apneseth
Improved and shortened prime_check.py (TheAlgorithms#3454)
893dd3f 
* Made small improvements and shortened prime_check.py

* improved descriptions on tests in prime_check.py

* Ran black and isort
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@Rolv-Apneseth @shermanhui
Improved and shortened prime_check.py (TheAlgorithms#3454)
e6a4de0 
* Made small improvements and shortened prime_check.py

* improved descriptions on tests in prime_check.py

* Ran black and isort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rolv-Apneseth @poyea