Skip to content

Fix documentation on [arithmetic_analysis] folder (#2510) #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fix documentation on [arithmetic_analysis] folder (#2510) #3274

wants to merge 6 commits into from

Conversation

Ed1123
Copy link

@Ed1123 Ed1123 commented Oct 14, 2020

Describe your change:

I have reviewed all files in .../Python/arithmetic_analysis, added documentation, some tests and style according to the [CONTRIBUTING.md]. I've tried to keep most of the original code. Most of the changes are minimum and all of them can be reviewed in less than a minute. That's why I keep them all in just one PR.
#2510

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Travis tests have failed

Hey @Ed1123,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 26c27950-0dd0-11eb-9111-f326d0cb7f09

@Ed1123
Copy link
Author

Ed1123 commented Oct 14, 2020

Apparently Travis CI is failing on a file I haven't modified:

=================================== FAILURES ===================================
_______________ [doctest] quantum.not_gate.single_qubit_measure _______________

Could you please check, @poyea? Sorry it I did something obvious wrong. this is my first PR.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Used to mark an issue or pull request stale. label Nov 13, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale bot closed this Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale Used to mark an issue or pull request stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ed1123 @TravisBuddy