Skip to content

Update CODEOWNERS to add my preferences #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2020
Merged

Update CODEOWNERS to add my preferences #3233

merged 2 commits into from
Oct 12, 2020

Conversation

Kush1101
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Kush1101 Kush1101 requested a review from cclauss as a code owner October 12, 2020 14:19
@cclauss cclauss merged commit 08c26e6 into master Oct 12, 2020
@cclauss cclauss deleted the Kush1101-patch-1 branch October 12, 2020 14:23
@dhruvmanila
Copy link
Member

Um, you have to uncomment the directory line also lol :) @Kush1101 @cclauss

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Kush1101 @stokhos
Update CODEOWNERS to add my preferences (TheAlgorithms#3233)
4eb46ee 
* Update CODEOWNERS

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Kush1101
Update CODEOWNERS to add my preferences (TheAlgorithms#3233)
aa0a358 
* Update CODEOWNERS

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kush1101 @dhruvmanila @cclauss