Skip to content

Changes functions name, add type hints and default args to problems 15 and 34 #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2020
Merged

Changes functions name, add type hints and default args to problems 15 and 34 #3076

merged 4 commits into from
Oct 9, 2020

Conversation

JuanJTorres11
Copy link
Contributor

Describe your change:

Contributes to #2786

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.

@dhruvmanila dhruvmanila merged commit 216a194 into TheAlgorithms:master Oct 9, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@JuanJTorres11 @dhruvmanila @stokhos
[Project Euler] Fix code style for problems 15 and 34 (TheAlgorithms#…
0d74d0b 
…3076)

* Add type hints and default args to problem 15

* Changes function's name to solution in problem 34

* Update sol1.py

* Update sol1.py

Co-authored-by: Dhruv <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@JuanJTorres11 @dhruvmanila
[Project Euler] Fix code style for problems 15 and 34 (TheAlgorithms#…
ca055cc 
…3076)

* Add type hints and default args to problem 15

* Changes function's name to solution in problem 34

* Update sol1.py

* Update sol1.py

Co-authored-by: Dhruv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuanJTorres11 @dhruvmanila