Hacktoberfest 2020 - coding style changes for project_euler problem 36 and 35 #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix one more problem as the number of files are decreasing per problem so it doesn't make sense to open a PR with such a small change? Commit the fix in this PR. |
|
Sounds good. I added a commit for problem 35 as well |
nstoik
changed the title
dhruvmanila
approved these changes
Oct 9, 2020
dhruvmanila
added
the
hacktoberfest-accepted
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…s#3062) * add problem url. Add typehint, default value and doctest * run black * add project url. add solution function for problem 35 * add space between imports on problem 35 * Update sol1.py * Update sol1.py Co-authored-by: Dhruv <[email protected]>
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
…s#3062) * add problem url. Add typehint, default value and doctest * run black * add project url. add solution function for problem 35 * add space between imports on problem 35 * Update sol1.py * Update sol1.py Co-authored-by: Dhruv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Add project url. Add default argument values, typehints and doctests
Related: #2786
Checklist:
Fixes: #{$ISSUE_NO}.