Skip to content

Add default args and type hints for Project Euler problem 20 #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions project_euler/problem_20/sol1.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
"""
Problem 20: https://projecteuler.net/problem=20

n! means n × (n − 1) × ... × 3 × 2 × 1

For example, 10! = 10 × 9 × ... × 3 × 2 × 1 = 3628800,
Expand All @@ -8,14 +10,15 @@
"""


def factorial(n):
def factorial(num: int) -> int:
"""Find the factorial of a given number n"""
fact = 1
for i in range(1, n + 1):
for i in range(1, num + 1):
fact *= i
return fact


def split_and_add(number):
def split_and_add(number: int) -> int:
"""Split number digits and add them."""
sum_of_digits = 0
while number > 0:
Expand All @@ -25,8 +28,8 @@ def split_and_add(number):
return sum_of_digits


def solution(n):
"""Returns the sum of the digits in the number 100!
def solution(num: int = 100) -> int:
"""Returns the sum of the digits in the factorial of num
>>> solution(100)
648
>>> solution(50)
Expand All @@ -42,8 +45,8 @@ def solution(n):
>>> solution(1)
1
"""
f = factorial(n)
result = split_and_add(f)
nfact = factorial(num)
result = split_and_add(nfact)
return result


Expand Down
8 changes: 5 additions & 3 deletions project_euler/problem_20/sol2.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
"""
Problem 20: https://projecteuler.net/problem=20

n! means n × (n − 1) × ... × 3 × 2 × 1

For example, 10! = 10 × 9 × ... × 3 × 2 × 1 = 3628800,
Expand All @@ -9,8 +11,8 @@
from math import factorial


def solution(n):
"""Returns the sum of the digits in the number 100!
def solution(num: int = 100) -> int:
"""Returns the sum of the digits in the factorial of num
>>> solution(100)
648
>>> solution(50)
Expand All @@ -26,7 +28,7 @@ def solution(n):
>>> solution(1)
1
"""
return sum([int(x) for x in str(factorial(n))])
return sum([int(x) for x in str(factorial(num))])


if __name__ == "__main__":
Expand Down
8 changes: 5 additions & 3 deletions project_euler/problem_20/sol3.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
"""
Problem 20: https://projecteuler.net/problem=20

n! means n × (n − 1) × ... × 3 × 2 × 1

For example, 10! = 10 × 9 × ... × 3 × 2 × 1 = 3628800,
Expand All @@ -9,8 +11,8 @@
from math import factorial


def solution(n):
"""Returns the sum of the digits in the number 100!
def solution(num: int = 100) -> int:
"""Returns the sum of the digits in the factorial of num
>>> solution(1000)
10539
>>> solution(200)
Expand All @@ -32,7 +34,7 @@ def solution(n):
>>> solution(0)
1
"""
return sum(map(int, str(factorial(n))))
return sum(map(int, str(factorial(num))))


if __name__ == "__main__":
Expand Down
8 changes: 5 additions & 3 deletions project_euler/problem_20/sol4.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
"""
Problem 20: https://projecteuler.net/problem=20

n! means n × (n − 1) × ... × 3 × 2 × 1

For example, 10! = 10 × 9 × ... × 3 × 2 × 1 = 3628800,
Expand All @@ -8,8 +10,8 @@
"""


def solution(n):
"""Returns the sum of the digits in the number 100!
def solution(num: int = 100) -> int:
"""Returns the sum of the digits in the factorial of num
>>> solution(100)
648
>>> solution(50)
Expand All @@ -27,7 +29,7 @@ def solution(n):
"""
fact = 1
result = 0
for i in range(1, n + 1):
for i in range(1, num + 1):
fact *= i

for j in str(fact):
Expand Down