-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Added solution to Project Euler 69 #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
83ec2cd
7c53dda
a2109ee
56d1a11
2ff4b3e
fefce59
21650fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,66 @@ | ||||||||||||||||||||
""" | ||||||||||||||||||||
Totient maximum | ||||||||||||||||||||
Problem 69: https://projecteuler.net/problem=69 | ||||||||||||||||||||
|
||||||||||||||||||||
Euler's Totient function, φ(n) [sometimes called the phi function], | ||||||||||||||||||||
is used to determine the number of numbers less than n which are relatively prime to n. | ||||||||||||||||||||
For example, as 1, 2, 4, 5, 7, and 8, | ||||||||||||||||||||
are all less than nine and relatively prime to nine, φ(9)=6. | ||||||||||||||||||||
|
||||||||||||||||||||
n Relatively Prime φ(n) n/φ(n) | ||||||||||||||||||||
2 1 1 2 | ||||||||||||||||||||
3 1,2 2 1.5 | ||||||||||||||||||||
4 1,3 2 2 | ||||||||||||||||||||
5 1,2,3,4 4 1.25 | ||||||||||||||||||||
6 1,5 2 3 | ||||||||||||||||||||
7 1,2,3,4,5,6 6 1.1666... | ||||||||||||||||||||
8 1,3,5,7 4 2 | ||||||||||||||||||||
9 1,2,4,5,7,8 6 1.5 | ||||||||||||||||||||
10 1,3,7,9 4 2.5 | ||||||||||||||||||||
|
||||||||||||||||||||
It can be seen that n=6 produces a maximum n/φ(n) for n ≤ 10. | ||||||||||||||||||||
|
||||||||||||||||||||
Find the value of n ≤ 1,000,000 for which n/φ(n) is a maximum. | ||||||||||||||||||||
""" | ||||||||||||||||||||
|
||||||||||||||||||||
|
||||||||||||||||||||
def solution(n: int = 10 ** 6) -> int: | ||||||||||||||||||||
""" | ||||||||||||||||||||
Returns solution to problem. | ||||||||||||||||||||
Algorithm: | ||||||||||||||||||||
1. Precompute φ(k) for all natural k, k <= n using product formula (wikilink below) | ||||||||||||||||||||
https://en.wikipedia.org/wiki/Euler%27s_totient_function#Euler's_product_formula | ||||||||||||||||||||
|
||||||||||||||||||||
2. Find k/φ(k) for all k ≤ n and return the k that attains maximum | ||||||||||||||||||||
|
||||||||||||||||||||
>>> solution(10) | ||||||||||||||||||||
6 | ||||||||||||||||||||
|
||||||||||||||||||||
>>> solution(100) | ||||||||||||||||||||
30 | ||||||||||||||||||||
|
||||||||||||||||||||
>>> solution(9973) | ||||||||||||||||||||
2310 | ||||||||||||||||||||
|
||||||||||||||||||||
""" | ||||||||||||||||||||
|
||||||||||||||||||||
if n <= 0: | ||||||||||||||||||||
raise ValueError("Please enter a natural number") | ||||||||||||||||||||
|
||||||||||||||||||||
phi = list(range(0, n + 1)) | ||||||||||||||||||||
sarthaka1310 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||
for number in range(2, n + 1): | ||||||||||||||||||||
if phi[number] == number: | ||||||||||||||||||||
phi[number] -= 1 | ||||||||||||||||||||
for multiple in range(number * 2, n + 1, number): | ||||||||||||||||||||
phi[multiple] = (phi[multiple] // number) * (number - 1) | ||||||||||||||||||||
Comment on lines
+51
to
+55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That line always evaluates to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After I accepted this, the test failed. Are you sure of this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was a mistake on my part. I did not see that you were changing the later elements of the list in the nested There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm curious as to how did you not realize that your code would become incorrect without the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did know what happened but gave you the benefit of doubt. Here's an explanation of what went wrong: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dhruvmanila I have another open PR#2868 and would appreciate it if you could review that too. (Also, it uses the sieve creation similar to the phi constructed here) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As mentioned, only submit one PR at a time. I have a lot to go through so that might take days. Thank you for your cooperation. |
||||||||||||||||||||
|
||||||||||||||||||||
answer = 1 | ||||||||||||||||||||
for number in range(1, n + 1): | ||||||||||||||||||||
if (answer / phi[answer]) < (number / phi[number]): | ||||||||||||||||||||
answer = number | ||||||||||||||||||||
|
||||||||||||||||||||
return answer | ||||||||||||||||||||
|
||||||||||||||||||||
|
||||||||||||||||||||
if __name__ == "__main__": | ||||||||||||||||||||
print(solution()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Natural numbers are greater than 0 by definition. If you still want it, I'll commit :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please, or maybe write something like the input value must be greater than 0 and please put the
if
statement back as that was a mistake on my part. Did you not realize that your code would become incorrect without theif
statement?