Skip to content

Hacktoberfest 2020: Add style improvements for Project Euler Problem 03 #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 40 additions & 24 deletions project_euler/problem_03/sol1.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,43 @@

e.g. for 10, largest prime factor = 5. For 17, largest prime factor = 17.
"""

import math


def isprime(no):
if no == 2:
def isprime(num: int) -> bool:
"""Returns boolean representing primality of given number num.
>>> isprime(2)
True
>>> isprime(3)
True
>>> isprime(27)
False
>>> isprime(2999)
True
>>> isprime(0)
Traceback (most recent call last):
...
ValueError: Parameter num must be greater or equal to two.
>>> isprime(1)
Traceback (most recent call last):
...
ValueError: Parameter num must be greater or equal to two.
"""
if num <= 1:
raise ValueError("Parameter num must be greater or equal to two.")
if num == 2:
return True
elif no % 2 == 0:
elif num % 2 == 0:
return False
sq = int(math.sqrt(no)) + 1
for i in range(3, sq, 2):
if no % i == 0:
for i in range(3, int(math.sqrt(num)) + 1, 2):
if num % i == 0:
return False
return True


def solution(n):
def solution(n: int = 600851475143) -> int:
"""Returns the largest prime factor of a given number n.

>>> solution(13195)
29
>>> solution(10)
Expand Down Expand Up @@ -54,24 +73,21 @@ def solution(n):
raise TypeError("Parameter n must be int or passive of cast to int.")
if n <= 0:
raise ValueError("Parameter n must be greater or equal to one.")
maxNumber = 0
max_number = 0
if isprime(n):
return n
while n % 2 == 0:
n //= 2
if isprime(n):
return n
else:
while n % 2 == 0:
n = n / 2
if isprime(n):
return int(n)
else:
n1 = int(math.sqrt(n)) + 1
for i in range(3, n1, 2):
if n % i == 0:
if isprime(n / i):
maxNumber = n / i
break
elif isprime(i):
maxNumber = i
return maxNumber
for i in range(3, int(math.sqrt(n)) + 1, 2):
if n % i == 0:
if isprime(n / i):
max_number = n / i
break
elif isprime(i):
max_number = i
return max_number


if __name__ == "__main__":
Expand Down
3 changes: 1 addition & 2 deletions project_euler/problem_03/sol2.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@
"""


def solution(n):
def solution(n: int = 600851475143) -> int:
"""Returns the largest prime factor of a given number n.

>>> solution(13195)
29
>>> solution(10)
Expand Down
9 changes: 2 additions & 7 deletions project_euler/problem_03/sol3.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@
"""


def solution(n: int) -> int:
def solution(n: int = 600851475143) -> int:
"""Returns the largest prime factor of a given number n.

>>> solution(13195)
29
>>> solution(10)
Expand Down Expand Up @@ -52,12 +51,8 @@ def solution(n: int) -> int:
while n % i == 0:
n = n / i
i += 1

return int(ans)


if __name__ == "__main__":
# print(solution(int(input().strip())))
import doctest

doctest.testmod()
print(solution(int(input().strip())))