Skip to content

Implement the melkman anlgorithm for computing convex hulls #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2020
Merged

Implement the melkman anlgorithm for computing convex hulls #2916

merged 5 commits into from
Oct 29, 2020

Conversation

SimonLammer
Copy link
Contributor

@SimonLammer SimonLammer commented Oct 6, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Since the file didn't contain type hints at all, I didn't add them for this algorithm.
Is this file the correct place for the algorithm? It is not a divide and conquer algorithm, but it is a convex_hull algorithm.

@SimonLammer SimonLammer mentioned this pull request Oct 8, 2020
Closed
2 tasks
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 8, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @SimonLammer,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e8ee7930-0992-11eb-b9d6-41d4da7e5060

@TravisBuddy
Copy link

Travis tests have failed

Hey @SimonLammer,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 664c6120-0999-11eb-b9d6-41d4da7e5060

@TravisBuddy
Copy link

Travis tests have failed

Hey @SimonLammer,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d36267a0-0999-11eb-b9d6-41d4da7e5060

@SimonLammer
Copy link
Contributor Author

@poyea Is there anything else I should to revise?

@SimonLammer
Copy link
Contributor Author

@poyea ?

poyea
poyea approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea
Copy link
Member

poyea commented Oct 29, 2020

@SimonLammer Add a hacktoberfest tag in your fork to make this valid for Hacktoberfest. This should work.

@poyea poyea merged commit e20895a into TheAlgorithms:master Oct 29, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@stokhos
Implement the melkman anlgorithm for computing convex hulls (TheAlgor…
6886ab6 
…ithms#2916)

* Implement the melkman anlgorithm for computing convex hulls

* Link melkman algorithm description

* Format melkman algorithm code

* Add type hints to functions

* Fix build errors
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@peRFectBeliever
Implement the melkman anlgorithm for computing convex hulls (TheAlgor…
6a7201c 
…ithms#2916)

* Implement the melkman anlgorithm for computing convex hulls

* Link melkman algorithm description

* Format melkman algorithm code

* Add type hints to functions

* Fix build errors
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
Implement the melkman anlgorithm for computing convex hulls (TheAlgor…
4d59eee 
…ithms#2916)

* Implement the melkman anlgorithm for computing convex hulls

* Link melkman algorithm description

* Format melkman algorithm code

* Add type hints to functions

* Fix build errors
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@shermanhui
Implement the melkman anlgorithm for computing convex hulls (TheAlgor…
d8d3725 
…ithms#2916)

* Implement the melkman anlgorithm for computing convex hulls

* Link melkman algorithm description

* Format melkman algorithm code

* Add type hints to functions

* Fix build errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@kbakdev kbakdev kbakdev approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonLammer @TravisBuddy @poyea @kbakdev