Skip to content

Hacktoberfest 2020: Add default args, typehints, expand variable names, and fix solutions for PE prob 02 #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2020
Merged

Hacktoberfest 2020: Add default args, typehints, expand variable names, and fix solutions for PE prob 02 #2898

merged 4 commits into from
Oct 6, 2020

Conversation

archaengel
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Related: #2786

@archaengel
Fix typehints in project_euler/problem01
e70c27d 
Squashed commit of the following:

commit 6801d07
Author: Archaengel <[email protected]>
Date:   Mon Oct 5 16:40:10 2020 -0700

    Fix typehints in project_euler/problem01

commit 29afc3a
Author: Archaengel <[email protected]>
Date:   Mon Oct 5 15:06:34 2020 -0700

    Add typehints and default argument for project_euler/problem_01
@archaengel
Merge remote-tracking branch 'upstream/master' into master
cd03961
@archaengel
Merge remote-tracking branch 'upstream/master' into master
68c47af
@archaengel
Add default args, typehints, and expand variable names for PE prob 02
db03f25
@dhruvmanila dhruvmanila added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 6, 2020
dhruvmanila
dhruvmanila approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for your contribution.

@dhruvmanila dhruvmanila merged commit f36a2f6 into TheAlgorithms:master Oct 6, 2020
@archaengel
Copy link
Contributor Author

Of course, thank you for the review!

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@archaengel @stokhos
Hacktoberfest 2020: Apply style guidelines for Project Euler problem_…
bc606d1 
…02 (TheAlgorithms#2898)

* Fix typehints in project_euler/problem01

Squashed commit of the following:

commit 6801d07
Author: Archaengel <[email protected]>
Date:   Mon Oct 5 16:40:10 2020 -0700

    Fix typehints in project_euler/problem01

commit 29afc3a
Author: Archaengel <[email protected]>
Date:   Mon Oct 5 15:06:34 2020 -0700

    Add typehints and default argument for project_euler/problem_01

* Add default args, typehints, and expand variable names for PE prob 02
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@archaengel
Hacktoberfest 2020: Apply style guidelines for Project Euler problem_…
507c089 
…02 (TheAlgorithms#2898)

* Fix typehints in project_euler/problem01

Squashed commit of the following:

commit 6801d07
Author: Archaengel <[email protected]>
Date:   Mon Oct 5 16:40:10 2020 -0700

    Fix typehints in project_euler/problem01

commit 29afc3a
Author: Archaengel <[email protected]>
Date:   Mon Oct 5 15:06:34 2020 -0700

    Add typehints and default argument for project_euler/problem_01

* Add default args, typehints, and expand variable names for PE prob 02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archaengel @dhruvmanila