Skip to content

Hacktoberfest: Project Euler Solution Problem 77 #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Hacktoberfest: Project Euler Solution Problem 77 #2782

wants to merge 1 commit into from

Conversation

breezko
Copy link

@breezko breezko commented Oct 4, 2020 •
edited
Loading

Describe your change:

Added Euler Project Solution for Problem 77

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@breezko breezko changed the title Project Euler Solution Problem 77 Hacktoberfest: Project Euler Solution Problem 77 Oct 4, 2020
@breezko breezko mentioned this pull request Oct 4, 2020
Closed
2 tasks
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 5, 2020
dhruvmanila
dhruvmanila requested changes Oct 5, 2020
View reviewed changes
@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 5, 2020
@breezko breezko requested a review from dhruvmanila October 6, 2020 08:51
dhruvmanila
dhruvmanila requested changes Oct 10, 2020
View reviewed changes
project_euler/problem_77/sol1.py
@@ -0,0 +1,68 @@
"""
Prime summations
Problem 77
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the reference link to the problem

project_euler/problem_77/sol1.py
"""


def solution(length=5000) -> int:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def solution(length=5000) -> int:
def solution(length: int = 5000) -> int:

project_euler/problem_77/sol1.py


def solution(length=5000) -> int:
"""Ways to write sum of primes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Ways to write sum of primes
"""
Ways to write the sum of primes

project_euler/problem_77/sol1.py
Comment on lines +26 to +27
>>> solution()
71
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include more doctest

dhruvmanila
dhruvmanila reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement:

@breezko

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.

@GantaChaitra
Copy link

Hey @dhruvmanila .. i would like to contribute to this issue .. can I ?

@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@stale
Copy link

stale bot commented Nov 29, 2020

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale bot closed this Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila requested changes

Assignees
No one assigned
Labels
awaiting changes A maintainer has requested changes to this PR hacktoberfest-accepted Accepted to be counted towards Hacktoberfest require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html stale Used to mark an issue or pull request stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breezko @GantaChaitra @dhruvmanila @poyea