Skip to content

Fix: Multiple errors in fibonacci search. #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 8, 2020
Merged

Fix: Multiple errors in fibonacci search. #2659

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
527ea43
Fix: Multiple errors in fibonacci search.
NumberPiOso Oct 2, 2020
78883cc
Fix: sort of modules and delete typehint.
Oct 2, 2020
3164b15
Apply suggestions from code review
NumberPiOso Oct 4, 2020
e8f5133
Correct invocation of lru_cache.
Oct 4, 2020
64cc42b
Add check for input in fibonacci and doctest.
Oct 4, 2020
15700dd
Correct typehints to comply to numpy style.
Oct 4, 2020
d7fad2a
Correct ValueError to TypeError.
NumberPiOso Oct 7, 2020
5c224eb
Correct doctest for TypeError.
Oct 7, 2020
96a5b6a
Rename single letter names as mentioned in CONTRIBUTING.md.
Oct 7, 2020
c323462
Fix: Bug in big lists.
Oct 7, 2020
5bdc2df
Remove print(.) in doctests.
Oct 7, 2020
e941ec0
Refactor iterator to while loop.
Oct 7, 2020
91c885a
Update searches/fibonacci_search.py
dhruvmanila Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions searches/fibonacci_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,17 @@ def fibonacci(k: int) -> int:
5
>>> print(fibonacci(15))
610
>>> print(fibonacci('a'))
Traceback (most recent call last):
ValueError: k must be an integer.
>>> print(fibonacci(-5))
Traceback (most recent call last):
ValueError: k integer must be greater or equal to zero.
"""
if not isinstance(k, int):
raise ValueError("k must be an integer.")
if k < 0:
raise ValueError("k integer must be greater or equal to zero.")
if k == 0:
return 0
elif k == 1:
Expand Down