Skip to content

math/sieve_of_eratosthenes: add type hints #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 23, 2020
Merged

math/sieve_of_eratosthenes: add type hints #2627

merged 6 commits into from
Nov 23, 2020

Conversation

pikulet
Copy link
Contributor

@pikulet pikulet commented Oct 1, 2020 •
edited
Loading

Describe your change:

just for completeness of existing code to follow the (now compulsory) requirements of type hints

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pikulet pikulet changed the title math/sieve of eras: add type hitns and doctest math/sieve_of_eratosthenes: add type hints and doctest Oct 1, 2020
@pikulet pikulet changed the title math/sieve_of_eratosthenes: add type hints and doctest math/sieve_of_eratosthenes: add type hints Oct 2, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
dhruvmanila
dhruvmanila requested changes Nov 23, 2020
View reviewed changes
@ghost ghost added the awaiting changes A maintainer has requested changes to this PR label Nov 23, 2020
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Nov 23, 2020
@ghost ghost added the require descriptive names This PR needs descriptive function and/or variable names label Nov 23, 2020
@dhruvmanila dhruvmanila removed the request for review from Kush1101 November 23, 2020 05:29
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 23, 2020
@ghost ghost removed require descriptive names This PR needs descriptive function and/or variable names tests are failing Do not merge until tests pass labels Nov 23, 2020
dhruvmanila
dhruvmanila approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@ghost ghost removed the awaiting changes A maintainer has requested changes to this PR label Nov 23, 2020
@dhruvmanila dhruvmanila merged commit 03e7f37 into TheAlgorithms:master Nov 23, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@pikulet @dhruvmanila @stokhos
[mypy] math/sieve_of_eratosthenes: Add type hints (TheAlgorithms#2627)
68310f8 
* add type hints to math/sieve
* add doctest
* math/sieve: remove manual doctest
* add check for negative
* Update maths/sieve_of_eratosthenes.py
* Update sieve_of_eratosthenes.py

Co-authored-by: Dhruv Manilawala <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@pikulet @dhruvmanila @peRFectBeliever
[mypy] math/sieve_of_eratosthenes: Add type hints (TheAlgorithms#2627)
18416c2 
* add type hints to math/sieve
* add doctest
* math/sieve: remove manual doctest
* add check for negative
* Update maths/sieve_of_eratosthenes.py
* Update sieve_of_eratosthenes.py

Co-authored-by: Dhruv Manilawala <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@pikulet @dhruvmanila
[mypy] math/sieve_of_eratosthenes: Add type hints (TheAlgorithms#2627)
3dff5f1 
* add type hints to math/sieve
* add doctest
* math/sieve: remove manual doctest
* add check for negative
* Update maths/sieve_of_eratosthenes.py
* Update sieve_of_eratosthenes.py

Co-authored-by: Dhruv Manilawala <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@pikulet @dhruvmanila @shermanhui
[mypy] math/sieve_of_eratosthenes: Add type hints (TheAlgorithms#2627)
103b150 
* add type hints to math/sieve
* add doctest
* math/sieve: remove manual doctest
* add check for negative
* Update maths/sieve_of_eratosthenes.py
* Update sieve_of_eratosthenes.py

Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbakdev kbakdev kbakdev approved these changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pikulet @kbakdev @dhruvmanila