Skip to content

math/extended_euclidean_algorithm: add doctests and support for negative numbers #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 7, 2020
Merged

math/extended_euclidean_algorithm: add doctests and support for negative numbers #2626

merged 6 commits into from
Oct 7, 2020

Conversation

pikulet
Copy link
Contributor

@pikulet pikulet commented Oct 1, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pikulet pikulet changed the title add type hints to math/extended_euclidean_algorithm math/extended_euclidean_algorithm: add type hints and doctest Oct 1, 2020
@dhruvmanila
Copy link
Member

As mentioned in #2630, can you make the appropriate changes for the algorithm to handle negative numbers?

@pikulet pikulet changed the title math/extended_euclidean_algorithm: add type hints and doctest math/extended_euclidean_algorithm: add doctests and support for negative numbers Oct 2, 2020
@pikulet
Copy link
Contributor Author

pikulet commented Oct 2, 2020 •
edited
Loading

done. resolves #2630

@dhruvmanila dhruvmanila linked an issue Oct 5, 2020 that may be closed by this pull request
math/extended_euclidean_algorithm cannot properly handle negative numbers #2630
Closed
dhruvmanila
dhruvmanila requested changes Oct 7, 2020
View reviewed changes
dhruvmanila
dhruvmanila approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@dhruvmanila dhruvmanila merged commit e41d041 into TheAlgorithms:master Oct 7, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@pikulet @dhruvmanila @stokhos
Fixes: TheAlgorithms#2630 Add doctests and support for negative numbe…
fc75944 
…rs (TheAlgorithms#2626)

* add type hints to math/extended euclid

* math/extended euclid - add doctest

* math/extended euclid: remove manual doctest

* change algorithm for negative numbers

* improve naming of variables

* Update extended_euclidean_algorithm.py

Co-authored-by: Dhruv <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@pikulet @dhruvmanila
Fixes: TheAlgorithms#2630 Add doctests and support for negative numbe…
1a5c7b7 
…rs (TheAlgorithms#2626)

* add type hints to math/extended euclid

* math/extended euclid - add doctest

* math/extended euclid: remove manual doctest

* change algorithm for negative numbers

* improve naming of variables

* Update extended_euclidean_algorithm.py

Co-authored-by: Dhruv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

math/extended_euclidean_algorithm cannot properly handle negative numbers
2 participants
@pikulet @dhruvmanila