Created problem_112.py in project_euler

[Kush1101]

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[Kush1101]

@shellhub, @dhruvmanila would be interested in reviewing this?

[realDuYuanChao]

Please test from percent from 1 to 99. I think i will won’t run forever. Kushagra Bansal <[email protected]>于2020年10月1日 周四17:09写道：

…

***@***.**** commented on this pull request. ------------------------------ In project_euler/problem_112/sol1.py <#2532 (comment)>: > + ... + ValueError: solution() only accepts values from 0 to 100 + >>> solution(100.011) + Traceback (most recent call last): + ... + ValueError: solution() only accepts values from 0 to 100 + """ + if percent >= 100: + raise ValueError("solution() only accepts values from 0 to 100") + bouncy_num = 0 + num = 1 + + while True: + if check_bouncy(num): + bouncy_num += 1 + if (bouncy_num / num) * 100 >= percent: For 99% per cent, it will find an exact integer. But for some given percentages, the number will number be exactly as the input per cent and if I put == the program will run forever, so I have to put >= — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2532 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHYQFV6T24IYTQ2VMDA46HTSIRBNTANCNFSM4R7OISPQ> .

[Kush1101]

But you can have float percentages as well. Testing it for 99.2 or 99.3 will not yield results if we have ==

[Kush1101]

I think it can be merged now.

[dhruvmanila]

@Kush1101 Do you mean that if we keep the __init__.py file empty the tests are failing?
Can you point out which tests are failing?

[Kush1101]

@Kush1101 Do you mean that if we keep the __init__.py file empty the tests are failing?
Can you point out which tests are failing?

Travis CI tests.

[Kush1101]

@cclauss I think it's up to you now. Can you review it?

[dhruvmanila]

I don't think so because almost all the __init__.py files are empty. Can you provide me the link for the build which failed due to this issue? That would be really helpful in finding out what's going on. Thanks.

[Kush1101]

I don't think so because almost all the __init__.py files are empty. Can you provide me the link for the build which failed due to this issue? That would be really helpful in finding out what's going on. Thanks.
You can see it now. It's actually the pre-commit test that fails.

[realDuYuanChao]

delete empty line. and try it.

[dhruvmanila]

Merging is blocked as @shellhub requested some changes. Maybe only he can merge this?

[realDuYuanChao]

LGTM.