Skip to content

Update sorts/quick_sort_3_partition.py #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Update sorts/quick_sort_3_partition.py #2507

merged 4 commits into from
Sep 29, 2020

Conversation

taseikyo
Copy link
Contributor

@taseikyo taseikyo commented Sep 29, 2020

Another quick sort algorithm, returns a new sorted list

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Another quick sort algorithm, returns a new sorted list
@TravisBuddy
Copy link

Hey @taseikyo,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0386d740-0206-11eb-aba2-872ffb2742c8

rename quick_sort_3partition to quick_sort_3part
@taseikyo
Copy link
Contributor Author

I am not a fan of this change. What about three_way_quicksort() ?

Are we trying to do https://en.wikipedia.org/wiki/Quicksort#Three-way_radix_quicksort or https://en.wikipedia.org/wiki/Multi-key_quicksort ?
Or is there some other webpage that describes the algorithm that we are implementing?

Yes, we are implementing https://en.wikipedia.org/wiki/Quicksort#Three-way_radix_quicksort. First divide the list into three parts. Then recursively sort the "less than" and "greater than" partitions.

rename quick_sort_3part to three_way_radix_quicksort
Three-way radix quicksort:
https://en.wikipedia.org/wiki/Quicksort#Three-way_radix_quicksort
First divide the list into three parts.
Then recursively sort the "less than" and "greater than" partitions.
@@ -1,4 +1,4 @@
def quick_sort_3partition(sorting: list, left: int, right: int) -> list:
def quick_sort_3partition(sorting: list, left: int, right: int):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick_sort_3partition does not return a new list, it just updates in place. So I remove -> list.

@taseikyo taseikyo changed the title Update sorts/quick_sort_3partition.py Update sorts/quick_sort_3_partition.py Sep 29, 2020
@cclauss cclauss merged commit e166350 into TheAlgorithms:master Sep 29, 2020
@taseikyo taseikyo deleted the patch branch September 29, 2020 12:31
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Update sorts/quick_sort_3partition.py

Another quick sort algorithm, returns a new sorted list

* Update sorts/quick_sort_3_partition.py

rename quick_sort_3partition to quick_sort_3part

* Update sorts/quick_sort_3_partition.py

rename quick_sort_3part to three_way_radix_quicksort
Three-way radix quicksort:
https://en.wikipedia.org/wiki/Quicksort#Three-way_radix_quicksort
First divide the list into three parts.
Then recursively sort the "less than" and "greater than" partitions.

* Update sorts/quick_sort_3_partition.py

Co-authored-by: Christian Clauss <[email protected]>

Co-authored-by: Christian Clauss <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Update sorts/quick_sort_3partition.py

Another quick sort algorithm, returns a new sorted list

* Update sorts/quick_sort_3_partition.py

rename quick_sort_3partition to quick_sort_3part

* Update sorts/quick_sort_3_partition.py

rename quick_sort_3part to three_way_radix_quicksort
Three-way radix quicksort:
https://en.wikipedia.org/wiki/Quicksort#Three-way_radix_quicksort
First divide the list into three parts.
Then recursively sort the "less than" and "greater than" partitions.

* Update sorts/quick_sort_3_partition.py

Co-authored-by: Christian Clauss <[email protected]>

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants