Skip to content

Update maths/area.py #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Update maths/area.py #2501

merged 1 commit into from
Sep 28, 2020

Conversation

taseikyo
Copy link
Contributor

The parameters of the geometric shapes should be non-negative values

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

the parameters of geometric shapes should be non-negative values
@realDuYuanChao
Copy link
Member

LGTM.

@realDuYuanChao realDuYuanChao merged commit 121dddc into TheAlgorithms:master Sep 28, 2020
@cclauss
Copy link
Member

cclauss commented Sep 28, 2020

in these algorithms, does it make sense for the radius to be 0?

@realDuYuanChao
Copy link
Member

Yes. It does not make sense if radius equal 0. Should we revert this PR ?

@cclauss
Copy link
Member

cclauss commented Sep 28, 2020

No need to revert. Just create a new PR to improve things.

@taseikyo
Copy link
Contributor Author

I think it makes sense for the radius to be 0, which means the shape doesn't exist. So, when I wrote the code yesterday, I set the condition to be non-negative.

@taseikyo taseikyo deleted the patch branch September 29, 2020 01:18
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
the parameters of geometric shapes should be non-negative values
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
the parameters of geometric shapes should be non-negative values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants