Skip to content

Update insert sort #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2020
Merged

Update insert sort #2493

merged 4 commits into from
Oct 3, 2020

Conversation

realDuYuanChao
Copy link
Member

update insert sort

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@realDuYuanChao
delete duplicate file
1e13cd4 
update insert sort
vdnhi
vdnhi previously requested changes Sep 28, 2020
View reviewed changes
@realDuYuanChao
Copy link
Member Author

realDuYuanChao commented Oct 3, 2020 •
edited
Loading

@cclauss @nomisrevol @poyea @dhruvmanila Build passed. I think this PR can be merged now.

@realDuYuanChao
Copy link
Member Author

@cclauss @nomisrevol @poyea @dhruvmanila Do you have time to review this ?

dhruvmanila
dhruvmanila approved these changes Oct 3, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I got busy then.
Looks good. Awesome work!

@dhruvmanila dhruvmanila dismissed vdnhi’s stale review October 3, 2020 15:18

The changes requested has been made by the author.

@dhruvmanila dhruvmanila merged commit 43f9249 into TheAlgorithms:master Oct 3, 2020
@realDuYuanChao realDuYuanChao deleted the insert_sort branch October 3, 2020 15:29
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao @stokhos
Update insert sort (TheAlgorithms#2493)
136c452 
* delete duplicate file
update insert sort

* rename

* fixed error

* using enumerate()
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@realDuYuanChao
Update insert sort (TheAlgorithms#2493)
ea34027 
* delete duplicate file
update insert sort

* rename

* fixed error

* using enumerate()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@vdnhi vdnhi vdnhi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@realDuYuanChao @cclauss @vdnhi @dhruvmanila