Skip to content

Updated circular_linked_list #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 26, 2020
Merged

Updated circular_linked_list #2483

merged 10 commits into from
Sep 26, 2020

Conversation

realDuYuanChao
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Sep 25, 2020
View reviewed changes
cclauss
cclauss reviewed Sep 25, 2020
View reviewed changes
cclauss
cclauss requested changes Sep 25, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we removed a lot of tests and did not add new ones.

@cclauss
Copy link
Member

cclauss commented Sep 26, 2020

What parts of this code have no tests?

@realDuYuanChao
Copy link
Member Author

realDuYuanChao commented Sep 26, 2020 •
edited
Loading

I tested all fuctions in test_circular_linked_list() function.

@realDuYuanChao
Copy link
Member Author

I don't test print_list() function. We do need test it ? @cclauss

cclauss
cclauss reviewed Sep 26, 2020
View reviewed changes
data_structures/linked_list/circular_linked_list.py

for i in range(5):
assert len(circular_linked_list) == i
circular_linked_list.insert_nth(i, i + 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add another is_empty() test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this ?

    assert circular_linked_list.is_empty() is True
    for i in range(5):
        assert len(circular_linked_list) == i
        circular_linked_list.insert_nth(i, i + 1)

@cclauss
Copy link
Member

cclauss commented Sep 26, 2020

Please delete .print_list() as it is completely redundant.

realDuYuanChao
realDuYuanChao commented Sep 26, 2020
View reviewed changes
Copy link
Member Author

@realDuYuanChao realDuYuanChao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted print_list() and test is_empty() again.

realDuYuanChao
realDuYuanChao commented Sep 26, 2020
View reviewed changes
@realDuYuanChao
Copy link
Member Author

Done. @cclauss

@TravisBuddy
Copy link

Hey @shellhub,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 55fa7750-0000-11eb-9882-0125ab0f75bf

realDuYuanChao
realDuYuanChao commented Sep 26, 2020
View reviewed changes
Copy link
Member Author

@realDuYuanChao realDuYuanChao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed indentation

@realDuYuanChao
Copy link
Member Author

@cclauss Please review again :)

cclauss
cclauss approved these changes Sep 26, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@realDuYuanChao realDuYuanChao merged commit 7f48bb8 into TheAlgorithms:master Sep 26, 2020
@realDuYuanChao realDuYuanChao deleted the circular_linked_list branch September 26, 2020 14:57
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao @cclauss @stokhos
Updated circular_linked_list (TheAlgorithms#2483)
34eb632 
* Updated circular_linked_list

* fixup! Format Python code with psf/black push

* Update data_structures/linked_list/circular_linked_list.py

Co-authored-by: Christian Clauss <[email protected]>

* updating DIRECTORY.md

* delete print_list()

* test is_empty()

* test is_empty return False

* fixup! Format Python code with psf/black push

* fixed indentation

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realDuYuanChao @cclauss @TravisBuddy