Reduce complexity linear_discriminant_analysis.

[NumberPiOso]

Tracking issue #2128

Describe your change:

• Fix a bug or typo in an existing algorithm?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• [ X All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Not really know how to create doctests for this kind of input functions.

[TravisBuddy]

Hey @NumberPiOso,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: bde32920-fabf-11ea-8017-3168cf2e728c

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[NumberPiOso]

How do I get for someone to review this?

[dhruvmanila]

Sorry for taking so long, just a few small changes and this is good to go.

[NumberPiOso]

@dhruvmanila

I just get one check from the Travis CI system, nothing from pre-commit.

Does this mean that it is good to go or that something is bad?

[dhruvmanila]

Your branch is based off on a very old commit, the psf/black automated action is deprecated. Also, do not start the workflow runs on your forked copy as some action might be automated which will make commits to your branch and that will come in this pull request as well.

Always update your fork copy to keep in sync with the main repository. If you want to make a pull request, make a branch from the latest copy and then make your changes in that branch.

The branch this PR based off is around 200 commits behind the master branch of this repository.

[NumberPiOso]

Yes I get it, I suppose I always start the branches from the lastest commit.

But this pull request has been open since 19 September, almost two months, so I guess this explains why it is 200 commits behind.

If it is better to start another pull request cherry picking this changes or something let me know.

[dhruvmanila]

I think rebasing should be enough, if that won't work then try cherry-picking otherwise another PR seems like the easiest option :)

[dhruvmanila]

This seems good to go. Thank you for your contribution! And sorry for the late review.

[NumberPiOso]

Thank you for the review.