-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
graphs/kruskal: add a test case to verify the correctness, fix styles #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c8bba8f
test/graphs/kruskal: adding a test case to verify the correctness of …
meysam81 e2c958f
grahps/kruskal: running psf/black
meysam81 4d3fb7e
graphs/kruskal: read edges in a friendlier fashion
meysam81 6ca51e4
Update minimum_spanning_tree_kruskal.py
poyea 06d69bb
fixup! Format Python code with psf/black push
07e9514
Update test_min_spanning_tree_kruskal.py
poyea 9a119cf
updating DIRECTORY.md
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
from graphs.minimum_spanning_tree_kruskal import run_algorithm as kruskal | ||
|
||
|
||
def test_kruskal_successful_result(): | ||
num_nodes, num_edges = 9, 14 | ||
edges = [[0, 1, 4], | ||
[0, 7, 8], | ||
[1, 2, 8], | ||
[7, 8, 7], | ||
[7, 6, 1], | ||
[2, 8, 2], | ||
[8, 6, 6], | ||
[2, 3, 7], | ||
[2, 5, 4], | ||
[6, 5, 2], | ||
[3, 5, 14], | ||
[3, 4, 9], | ||
[5, 4, 10], | ||
[1, 7, 11]] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. psf/black will reformat the matrices. |
||
|
||
result = kruskal(num_nodes, num_edges, edges) | ||
|
||
expected = [[7, 6, 1], | ||
[2, 8, 2], | ||
[6, 5, 2], | ||
[0, 1, 4], | ||
[2, 5, 4], | ||
[2, 3, 7], | ||
[0, 7, 8], | ||
[3, 4, 9]] | ||
|
||
assert sorted(expected) == sorted(result) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Python type hints on function parameters and the return type.
Does num_edges always equal len(edges)? If so, let’s not force the caller to provide us num_edges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding type hints was done in #3101 which you merged a couple of hours ago.
We can remove
num_edges
if you say so.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments were on my second computer and I never hit Send... Thanks for doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My pleasure 🥂