Create priority_queue_using_list.py #2428

Ashley-J-George · 2020-09-14T18:49:11Z

Implementation of Priority Queue using lists

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

Implementation of Priority Queue using lists

Corrected the spelling mistake of fashion

TravisBuddy · 2020-09-14T18:53:00Z

Hey @Ashley-J-George,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 820319e0-f6bb-11ea-afed-a1bc0e34d213

TravisBuddy · 2020-09-14T18:55:59Z

Hey @Ashley-J-George,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ecb0abe0-f6bb-11ea-afed-a1bc0e34d213

TravisBuddy · 2020-09-14T18:59:33Z

Hey @Ashley-J-George,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6c3441b0-f6bc-11ea-afed-a1bc0e34d213

TravisBuddy · 2020-09-14T19:07:04Z

Hey @Ashley-J-George,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 78e4e4e0-f6bd-11ea-afed-a1bc0e34d213

spamegg1 · 2020-09-14T19:32:22Z

@Ashley-J-George

7 E501 line too long (101 > 88 characters)

Run black on your file: https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md
pip install black then black priority_queue.py

data_structures/queue/priority_queue.py

cclauss · 2020-09-14T20:52:14Z

Seven lines are longer than 88 characters max.

Removed unwanted white spaces Kept the max char in a line under 88 char Added the suggested if condition for underflow Added the ellipse(...) instead of the entire traceback

TravisBuddy · 2020-09-15T07:57:04Z

Hey @Ashley-J-George,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 09b750f0-f729-11ea-bb1a-aff04add7ab5

data_structures/queue/priority_queue.py

spamegg1 · 2020-09-15T08:40:54Z

2 E501 line too long (90 > 88 characters)
1 W291 trailing whitespace

Can be easily fixed. Run black

data_structures/queue/priority_queue.py

cclauss · 2020-09-15T09:17:11Z

data_structures/queue/priority_queue.py

+        else:
+            return self.queue[2].pop(0)
+
+    def print_queue(self):


Suggested change

def print_queue(self):

def __str__(self) -> str:

return "Your code goes here..."

Instead, please do def __str__(self) -> str: and then we can use str(my_queue) or print(my_queue) to see the results.

How do you do that?

Replace "Your code goes here..." with a str that you want to see.

Added the proposed changes

TravisBuddy · 2020-09-15T11:06:55Z

Hey @Ashley-J-George,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8f540860-f743-11ea-bb1a-aff04add7ab5

cclauss · 2020-09-15T11:59:02Z

207 lines now start with indentation that contains tabs

Ashley-J-George · 2020-09-15T12:51:53Z

207 lines now start with indentation that contains tabs

All indentation are spaces

TravisBuddy · 2020-09-15T12:56:02Z

Hey @Ashley-J-George,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: cdbd5de0-f752-11ea-bb1a-aff04add7ab5

TravisBuddy · 2020-09-15T13:01:22Z

Travis tests have failed

Hey @Ashley-J-George,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8c02ee50-f753-11ea-bb1a-aff04add7ab5

TravisBuddy · 2020-09-15T14:41:11Z

Travis tests have failed

Hey @Ashley-J-George,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 64eddce0-f761-11ea-bb1a-aff04add7ab5

mikelane

I don't think this should be included as an example priority queue data structure.

data_structures/queue/priority_queue.py

Ashley-J-George · 2020-09-15T17:24:08Z

I don't think this should be included as an example priority queue data structure.
Tell me the changes that you want me to make and I'll try to incorporate them to my level best

cclauss · 2020-09-15T20:50:24Z

@Ashley-J-George please reopen this PR so that we can finish it. Despite the other comments, three levels is enough for this demonstration algorithm. Just because Priority queues often times use a heap does not mean that they always use a heap, so your list-based approach was fine. Using dequeue or heapq will hide many of the implementation details that make your simple list-based approach so educational. As we say in our README, we are building algorithms to be educational, to highlight concepts, not to be as fast as the Python standard library.

Ashley-J-George · 2020-09-16T14:39:13Z

I have submitted a pull request, you could just go through it.

…

On Wed, Sep 16, 2020 at 2:20 AM Christian Clauss ***@***.***> wrote: @Ashley-J-George <https://github.com/Ashley-J-George> please reopen this PR so that we can finish it. Despite the other comments, three levels is enough for this demonstration algorithm. Just because *Priority queues often times use a heap* does not mean that they always use a heap so your list-based approach was fine. Using dequeue or heapq will hide many of the implementation details that make your simple list-based so educational. As we say in our README, we are building algorithms to be educational, not to be as fast as the Python standard library. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2428 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJUYHLK2CVNAXRBSCHGXP6TSF7HSDANCNFSM4RL6NONA> .

cclauss · 2020-09-16T15:04:16Z

I am sitting down to go through it but the pull request is closed.

Ashley-J-George · 2020-09-16T15:11:40Z

I had closed the PR and deleted it yesterday so today I sent another new PR

…

On Wed, Sep 16, 2020 at 8:34 PM Christian Clauss ***@***.***> wrote: I am sitting down to go through it but the pull request is closed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2428 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJUYHLNJ4NAF3VL7YISI3NLSGDHYHANCNFSM4RL6NONA> .

cclauss · 2020-09-16T16:46:08Z

Merged in #2435

Ashley-J-George added 2 commits September 15, 2020 00:16

Create priority_queue.py

f3ebf4c

Implementation of Priority Queue using lists

Update priority_queue.py

3617e19

Corrected the spelling mistake of fashion

Update priority_queue.py

3529a68

Update priority_queue.py

3cdfb54

cclauss reviewed Sep 14, 2020

View reviewed changes

data_structures/queue/priority_queue.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 14, 2020

View reviewed changes

data_structures/queue/priority_queue.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 14, 2020

View reviewed changes

data_structures/queue/priority_queue.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 14, 2020

View reviewed changes

data_structures/queue/priority_queue.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 14, 2020

View reviewed changes

data_structures/queue/priority_queue.py Outdated Show resolved Hide resolved

Update priority_queue.py

9c17c2c

Removed unwanted white spaces Kept the max char in a line under 88 char Added the suggested if condition for underflow Added the ellipse(...) instead of the entire traceback

cclauss reviewed Sep 15, 2020

View reviewed changes

data_structures/queue/priority_queue.py Show resolved Hide resolved

cclauss reviewed Sep 15, 2020

View reviewed changes

data_structures/queue/priority_queue.py Show resolved Hide resolved

cclauss reviewed Sep 15, 2020

View reviewed changes

data_structures/queue/priority_queue.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 15, 2020

View reviewed changes

data_structures/queue/priority_queue.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 15, 2020

View reviewed changes

data_structures/queue/priority_queue.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 15, 2020

View reviewed changes

data_structures/queue/priority_queue.py Show resolved Hide resolved

cclauss reviewed Sep 15, 2020

View reviewed changes

Update priority_queue.py

738feef

Added the proposed changes

Ashley-J-George closed this Sep 15, 2020

Ashley-J-George reopened this Sep 15, 2020

Update priority_queue.py

735390b

All indentation are spaces

Update priority_queue.py

670887e

Ashley-J-George added 2 commits September 15, 2020 20:14

Update priority_queue.py

a5a13d2

Update priority_queue.py

8726046

mikelane suggested changes Sep 15, 2020

View reviewed changes

Ashley-J-George closed this Sep 15, 2020

Ashley-J-George deleted the patch-1 branch September 15, 2020 17:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create priority_queue_using_list.py #2428

Create priority_queue_using_list.py #2428

Ashley-J-George commented Sep 14, 2020 •

edited

Loading

TravisBuddy commented Sep 14, 2020

TravisBuddy commented Sep 14, 2020

TravisBuddy commented Sep 14, 2020

TravisBuddy commented Sep 14, 2020

spamegg1 commented Sep 14, 2020 •

edited

Loading

cclauss commented Sep 14, 2020

TravisBuddy commented Sep 15, 2020

spamegg1 commented Sep 15, 2020

cclauss Sep 15, 2020 •

edited

Loading

Ashley-J-George Sep 15, 2020

cclauss Sep 15, 2020 •

edited

Loading

TravisBuddy commented Sep 15, 2020

cclauss commented Sep 15, 2020

Ashley-J-George commented Sep 15, 2020

TravisBuddy commented Sep 15, 2020

TravisBuddy commented Sep 15, 2020

TravisBuddy commented Sep 15, 2020

mikelane left a comment

Ashley-J-George commented Sep 15, 2020

cclauss commented Sep 15, 2020 •

edited

Loading

Ashley-J-George commented Sep 16, 2020 via email

cclauss commented Sep 16, 2020 •

edited

Loading

Ashley-J-George commented Sep 16, 2020 via email

cclauss commented Sep 16, 2020

	def print_queue(self):
	def __str__(self) -> str:
	return "Your code goes here..."

Create priority_queue_using_list.py #2428

Create priority_queue_using_list.py #2428

Conversation

Ashley-J-George commented Sep 14, 2020 • edited Loading

Describe your change:

Checklist:

TravisBuddy commented Sep 14, 2020

TravisBuddy Request Identifier: 820319e0-f6bb-11ea-afed-a1bc0e34d213

TravisBuddy commented Sep 14, 2020

TravisBuddy Request Identifier: ecb0abe0-f6bb-11ea-afed-a1bc0e34d213

TravisBuddy commented Sep 14, 2020

TravisBuddy Request Identifier: 6c3441b0-f6bc-11ea-afed-a1bc0e34d213

TravisBuddy commented Sep 14, 2020

TravisBuddy Request Identifier: 78e4e4e0-f6bd-11ea-afed-a1bc0e34d213

spamegg1 commented Sep 14, 2020 • edited Loading

cclauss commented Sep 14, 2020

TravisBuddy commented Sep 15, 2020

TravisBuddy Request Identifier: 09b750f0-f729-11ea-bb1a-aff04add7ab5

spamegg1 commented Sep 15, 2020

cclauss Sep 15, 2020 • edited Loading

Choose a reason for hiding this comment

Ashley-J-George Sep 15, 2020

Choose a reason for hiding this comment

cclauss Sep 15, 2020 • edited Loading

Choose a reason for hiding this comment

TravisBuddy commented Sep 15, 2020

TravisBuddy Request Identifier: 8f540860-f743-11ea-bb1a-aff04add7ab5

cclauss commented Sep 15, 2020

Ashley-J-George commented Sep 15, 2020

TravisBuddy commented Sep 15, 2020

TravisBuddy Request Identifier: cdbd5de0-f752-11ea-bb1a-aff04add7ab5

TravisBuddy commented Sep 15, 2020

Travis tests have failed

TravisBuddy Request Identifier: 8c02ee50-f753-11ea-bb1a-aff04add7ab5

TravisBuddy commented Sep 15, 2020

Travis tests have failed

TravisBuddy Request Identifier: 64eddce0-f761-11ea-bb1a-aff04add7ab5

mikelane left a comment

Choose a reason for hiding this comment

Ashley-J-George commented Sep 15, 2020

cclauss commented Sep 15, 2020 • edited Loading

Ashley-J-George commented Sep 16, 2020 via email

cclauss commented Sep 16, 2020 • edited Loading

Ashley-J-George commented Sep 16, 2020 via email

cclauss commented Sep 16, 2020

Ashley-J-George commented Sep 14, 2020 •

edited

Loading

spamegg1 commented Sep 14, 2020 •

edited

Loading

cclauss Sep 15, 2020 •

edited

Loading

cclauss Sep 15, 2020 •

edited

Loading

cclauss commented Sep 15, 2020 •

edited

Loading

cclauss commented Sep 16, 2020 •

edited

Loading