-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
file-transfer: writing tests and ensuring that all is going well #2413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4bbbbca
file-transfer: writing tests and ensuring that all is going well
meysam81 92b3d0b
def send_file(filename: str = "mytext.txt", testing: bool = False) ->…
cclauss 3f49ad5
send_file(filename="mytext.txt", testing=True)
cclauss 223fd19
Update send_file.py
cclauss 1b75a5b
requirements.txt: lxml
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
from unittest.mock import patch, Mock | ||
|
||
|
||
from file_transfer.send_file import run_script as send_file | ||
|
||
|
||
@patch("socket.socket") | ||
@patch("builtins.open") | ||
def test_send_file_running_as_expected(file, sock): | ||
# ===== initialization ===== | ||
conn = Mock() | ||
sock.return_value.accept.return_value = conn, Mock() | ||
f = iter([1, None]) | ||
file.return_value.__enter__.return_value.read.side_effect = lambda _: next(f) | ||
|
||
# ===== invoke ===== | ||
send_file() | ||
|
||
# ===== ensurance ===== | ||
sock.assert_called_once() | ||
sock.return_value.bind.assert_called_once() | ||
sock.return_value.listen.assert_called_once() | ||
sock.return_value.accept.assert_called_once() | ||
conn.recv.assert_called_once() | ||
|
||
file.return_value.__enter__.assert_called_once() | ||
file.return_value.__enter__.return_value.read.assert_called() | ||
|
||
conn.send.assert_called_once() | ||
conn.close.assert_called_once() | ||
sock.return_value.shutdown.assert_called_once() | ||
sock.return_value.close.assert_called_once() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.