Skip to content

Perfect square using binary search #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2020
Merged

Perfect square using binary search #2351

merged 3 commits into from
Aug 25, 2020

Conversation

ihebu
Copy link
Contributor

@ihebu ihebu commented Aug 25, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
maths/perfect_square.py
>>> perfect_square_binary_search(0)
True
>>> perfect_square_binary_search(10)
False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests for -1, 1.1, "a", None, []?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I first add input validation inside the function, or should I just include those tests ?

Copy link
Member

@cclauss cclauss Aug 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write the tests first and see how your function deals with unexpected input. The trick is to not write validation code if you don't have to. If your function is already going to raise an IndexError, TypeError, ValueError, etc. then you have no work to do. Just look for cases where your code would silently fail or would deliver nonsense results.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.Thank you so much !
Things should be good now.

@cclauss cclauss merged commit 2c0127d into TheAlgorithms:master Aug 25, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@ihebu @stokhos
Perfect square using binary search (TheAlgorithms#2351)
25ccc0d 
* Add perfect_square_binary_search

* Update tests

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@swapnanildutta swapnanildutta swapnanildutta approved these changes

@rtvk007 rtvk007 rtvk007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ihebu @cclauss @swapnanildutta @rtvk007