Skip to content

Created problem_44 in project_euler #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 25, 2020
Merged

Created problem_44 in project_euler #2348

merged 10 commits into from
Aug 25, 2020

Conversation

Kush1101
Copy link
Member

@Kush1101 Kush1101 commented Aug 24, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Travis tests have failed

Hey @Kush1101,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5d3f2260-e5c8-11ea-904d-8d6db3931464

@TravisBuddy
Copy link

Travis tests have failed

Hey @Kush1101,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e3b923d0-e5c9-11ea-904d-8d6db3931464

@Kush1101
Copy link
Member Author

@cclauss Please review it.

cclauss
cclauss reviewed Aug 24, 2020
View reviewed changes
@Kush1101
Copy link
Member Author

@cclauss I made the changes. Please review again.

@Kush1101 Kush1101 requested a review from cclauss August 25, 2020 06:01
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
Kush1101 and others added 2 commits August 25, 2020 12:03
@Kush1101 Kush1101 requested a review from cclauss August 25, 2020 07:28
@cclauss cclauss merged commit 5cfc017 into TheAlgorithms:master Aug 25, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Kush1101 @cclauss @stokhos
Created problem_44 in project_euler (TheAlgorithms#2348)
08bf772 
* Create __int__.py

* Update and rename project_euler/__int__.py to project_euler/problem_44/__int__.py

* Add files via upload

* Update sol1.py

* Update __int__.py

* Delete __int__.py

* Create __init__.py

* Update project_euler/problem_44/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_44/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_44/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kush1101 @TravisBuddy @cclauss