Skip to content

Fix SettingWithCopy warning by pandas #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 23, 2020
Merged

Fix SettingWithCopy warning by pandas #2346

merged 7 commits into from
Aug 23, 2020

Conversation

zqbake
Copy link
Contributor

@zqbake zqbake commented Aug 22, 2020 •
edited
Loading

#2282

Describe your change:

#2282

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@zqbake zqbake changed the title Fix SettingWithCopy warning in pandas Fix SettingWithCopy warning by pandas Aug 22, 2020
@cclauss cclauss added the awaiting reviews This PR is ready to be reviewed label Aug 23, 2020
@TravisBuddy
Copy link

Hey @zhqu1148980644,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 05229300-e514-11ea-862b-338b6fa79dcf

@TravisBuddy
Copy link

Hey @zhqu1148980644,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: cc9986c0-e51c-11ea-862b-338b6fa79dcf

@TravisBuddy
Copy link

Hey @zhqu1148980644,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 03137300-e51d-11ea-862b-338b6fa79dcf

@cclauss cclauss merged commit d402cd0 into TheAlgorithms:master Aug 23, 2020
@cclauss
Copy link
Member

cclauss commented Aug 23, 2020

Thanks for doing this.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@zqbake @stokhos
Fix SettingWithCopy warning by pandas (TheAlgorithms#2346)
8fe9736 
* Fix SettingWithCopy warning in pandas

TheAlgorithms#2282

* Update k_means_clust.py

* Update k_means_clust.py

* Update k_means_clust.py

* Update k_means_clust.py

* Update k_means_clust.py

* Update k_means_clust.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zqbake @TravisBuddy @cclauss