Skip to content

Created problem_35 in project_euler #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 16, 2020
Merged

Created problem_35 in project_euler #2309

merged 18 commits into from
Aug 16, 2020

Conversation

Kush1101
Copy link
Member

@Kush1101 Kush1101 commented Aug 15, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f9109ac0-dec5-11ea-a02c-4f626b4af334

@Kush1101
Copy link
Member Author

@cclauss. Please review it.

Kush1101 and others added 2 commits August 15, 2020 22:15
@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 3870f470-df17-11ea-a7d8-3d177b5d5f1d

Kush1101 and others added 2 commits August 15, 2020 22:20
@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: dcc1c630-df17-11ea-a7d8-3d177b5d5f1d

Kush1101 and others added 2 commits August 15, 2020 23:43
@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8dd5f440-df23-11ea-a7d8-3d177b5d5f1d

@Kush1101
Copy link
Member Author

@cclauss sir. Can this be merged now?

@Kush1101
Copy link
Member Author

Please review it now. @cclauss

@cclauss cclauss merged commit 7e4176c into TheAlgorithms:master Aug 16, 2020
@cclauss
Copy link
Member

cclauss commented Aug 16, 2020

Nice! Please see the final change that I made to the last line of the file.

@Kush1101
Copy link
Member Author

Thanks for the help.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Kush1101 @cclauss @stokhos
Created problem_35 in project_euler (TheAlgorithms#2309)
28db199 
* Create __init__.py

* Update __init__.py

* Add files via upload

* Update sol1.py

* Update sol1.py to include type hints

* Update CONTRIBUTING.md to fix typo

* Update CONTRIBUTING.md

* Update project_euler/problem_35/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_35/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_35/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_35/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_35/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_35/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_35/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update sol1.py

* Update sol1.py

* Update sol1.py

* Fix the print(f"string")

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kush1101 @TravisBuddy @cclauss