Skip to content

Created problem_34 in project_euler #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 13, 2020
Merged

Created problem_34 in project_euler #2305

merged 23 commits into from
Aug 13, 2020

Conversation

Kush1101
Copy link
Member

@Kush1101 Kush1101 commented Aug 13, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 10bc62e0-dd5d-11ea-9bc7-ef10f4dac8ce

@TravisBuddy
Copy link

Travis tests have failed

Hey @Kush1101,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e262c6d0-dd5e-11ea-9bc7-ef10f4dac8ce

@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f1cd8b80-dd60-11ea-9bc7-ef10f4dac8ce

@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9a6b2220-dd61-11ea-9bc7-ef10f4dac8ce

@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0b87c750-dd63-11ea-9bc7-ef10f4dac8ce

@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6ffe9ec0-dd63-11ea-9bc7-ef10f4dac8ce

@Kush1101
Copy link
Member Author

Kush1101 commented Aug 13, 2020 •
edited
Loading

How do I create the init.py file so that it passes the tests?
I am only failing in the init.py test.
It says
Blank line at end of file.
I have removed it but still, it won't pass.
@cclauss sir, Please help.

@Kush1101
Copy link
Member Author

Thank You sir for your help. Hope this gets merged 🤞.

cclauss
cclauss requested changes Aug 13, 2020
View reviewed changes
@Kush1101
Update sol1.py
e551e5a 
Incorporates the proposed changes
@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1a5d5ea0-dd6a-11ea-9bc7-ef10f4dac8ce

cclauss
cclauss reviewed Aug 13, 2020
View reviewed changes
project_euler/problem_34/sol1.py Outdated
for num in range(3, 7 * factorial(9) + 1):
if sum_of_digit_factorial(num) == num:
summ += num
return summ
the_list.append(num)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this list using a https://docs.python.org/3/tutorial/datastructures.html#list-comprehensions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sir. Will do it

Kush1101 and others added 2 commits August 13, 2020 19:32
@TravisBuddy
Copy link

Travis tests have failed

Hey @Kush1101,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: dc9a1280-dd6d-11ea-9bc7-ef10f4dac8ce

@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 240dd9d0-dd6e-11ea-9bc7-ef10f4dac8ce

@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 89579c30-dd6f-11ea-9bc7-ef10f4dac8ce

@cclauss
Copy link
Member

cclauss commented Aug 13, 2020

Looks good to me... Should we land it??

@TravisBuddy
Copy link

Travis tests have failed

Hey @Kush1101,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6ada79c0-dd70-11ea-9bc7-ef10f4dac8ce

@Kush1101
Copy link
Member Author

Kush1101 commented Aug 13, 2020 •
edited
Loading

If the tests pass then can you please merge it.
@cclauss
The continuous failure is because of the tests is because of the syntax rules. I am not able to run black on my computer that is why the syntax errors are not being resolved.

@Kush1101
Copy link
Member Author

@cclauss
Can we merge now sir?

cclauss
cclauss approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work here! Thanks for your persistence.

@cclauss cclauss merged commit b3ae392 into TheAlgorithms:master Aug 13, 2020
@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: baf625e0-dd74-11ea-9bc7-ef10f4dac8ce

@Kush1101
Copy link
Member Author

Kush1101 commented Aug 13, 2020 •
edited
Loading

@cclauss Thank you sir for your patience.
I know you are extremely busy and I occupied too much of your attention.
I am a beginner sir and I will learn as I keep going under mentors like you. Thanks once again, sir. ✌

@Kush1101 Kush1101 mentioned this pull request Aug 25, 2020
Merged
14 tasks
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Kush1101 @cclauss @stokhos
Created problem_34 in project_euler (TheAlgorithms#2305)
8686967 
* Create __init__.py

* Add files via upload

* Rename solution.py.py to solution.py

* Delete __init__.py

* Update and rename solution.py to sol1.py

* Update sol1.py

* Create __init__.py

* Update __init__.py

* Delete __init__.py

* Add files via upload

* Update __init__.py

* Add #\n

* Update sol1.py

Incorporates the proposed changes

* Update sol1.py

* Update sol1.py

* Update project_euler/problem_34/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_34/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_34/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_34/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update sol1.py

* Update sol1.py

* Update sol1.py

* Use int(n) instead of floor(n)

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kush1101 @TravisBuddy @cclauss