Skip to content

More efficient least common multiple. #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2020
Merged

More efficient least common multiple. #2281

merged 4 commits into from
Aug 5, 2020

Conversation

fhlasek
Copy link
Contributor

@fhlasek fhlasek commented Aug 5, 2020 •
edited
Loading

Describe your change:

#2268
lowest_common_multiple_slow(): 105.55078284300001
lowest_common_multiple_fast(): 0.569782399999994

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Aadit-Garg
Copy link

Hello

@cclauss
Copy link
Member

cclauss commented Aug 5, 2020

Awesome contribution. Thanks!

@cclauss cclauss merged commit 871f8f4 into TheAlgorithms:master Aug 5, 2020
@TravisBuddy
Copy link

Hey @fhlasek,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0337f310-d708-11ea-85fc-4b61cecd2c91

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@fhlasek @cclauss @stokhos
More efficient least common multiple. (TheAlgorithms#2281)
d890905 
* More efficient least common multiple.

* lowest -> least

* integer division

* Update least_common_multiple.py

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fhlasek @Aadit-Garg @cclauss @TravisBuddy