Skip to content

Procentual proximity scoring algorithm implemented #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2020
Merged

Procentual proximity scoring algorithm implemented #2280

merged 3 commits into from
Aug 4, 2020

Conversation

markmelnic
Copy link
Contributor

@markmelnic markmelnic commented Aug 4, 2020 •
edited
Loading

  • Add an algorithm?

This is an algorithm which works based on a range based percentual proximity scoring principle. Initially I developed it for a personal project, however later I found out it is a form of Newton's method used in statistics to solve maximum likelihood equations numerically.

Changes from last pull request:

  • code pythonization
  • multiple improvements
  • passed doctest
  • passed flake8 test

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.

@markmelnic
Procentual proximity scoring algorithm implemented
f648334 
- added requested changes
- passed doctest

- passed flake8 test
cclauss
cclauss reviewed Aug 4, 2020
View reviewed changes
cclauss
cclauss reviewed Aug 4, 2020
View reviewed changes
@markmelnic markmelnic requested a review from cclauss August 4, 2020 20:07
cclauss
cclauss approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@cclauss cclauss merged commit a891f68 into TheAlgorithms:master Aug 4, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@markmelnic @cclauss @stokhos
Procentual proximity scoring algorithm implemented (TheAlgorithms#2280)
8c13a35 
* Procentual proximity scoring algorithm implemented

- added requested changes
- passed doctest

- passed flake8 test

* Apply suggestions from code review

Co-authored-by: Christian Clauss <[email protected]>

* Function rename

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markmelnic @cclauss