Skip to content

added type hints and doctests to arithmetic_analysis/newton_method.py #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2020
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 40 additions & 13 deletions arithmetic_analysis/newton_method.py
Original file line number Diff line number Diff line change
@@ -1,23 +1,50 @@
"""Newton's Method."""

# Newton's Method - https://en.wikipedia.org/wiki/Newton%27s_method


# function is the f(x) and function1 is the f'(x)
def newton(function, function1, startingInt):
x_n = startingInt
from typing import Callable

RealFunc = Callable[[float], float] # type alias for a real -> real function


# function is the f(x) and derivative is the f'(x)
def newton(function: RealFunc, derivative: RealFunc, starting_int: int,) -> float:
"""
>>> newton(lambda x: x ** 3 - 2 * x - 5, lambda x: 3 * x ** 2 - 2, 3)
2.0945514815423474
>>> newton(lambda x: x ** 3 - 1, lambda x: 3 * x ** 2, -2)
1.0
>>> newton(lambda x: x ** 3 - 1, lambda x: 3 * x ** 2, -4)
1.0000000000000102
>>> import math
>>> newton(math.sin, math.cos, 1)
0.0
>>> newton(math.sin, math.cos, 2)
3.141592653589793
>>> newton(math.cos, lambda x: -math.sin(x), 2)
1.5707963267948966
>>> newton(math.cos, lambda x: -math.sin(x), 0)
Traceback (most recent call last):
...
ZeroDivisionError: Could not find root
"""
prev_guess: float = starting_int
while True:
x_n1 = x_n - function(x_n) / function1(x_n)
if abs(x_n - x_n1) < 10 ** -5:
return x_n1
x_n = x_n1


def f(x):
try:
next_guess: float = prev_guess - function(prev_guess) / derivative(
prev_guess
)
if abs(prev_guess - next_guess) < 10 ** -5:
return next_guess
prev_guess = next_guess
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 36-38 can not raise a ZeroDivisionError so they should not be in the try block as discussed in PEP8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, didn't know that. Understood.

except ZeroDivisionError:
raise ZeroDivisionError("Could not find root")


def f(x: float) -> float:
return (x ** 3) - (2 * x) - 5


def f1(x):
def f1(x: float) -> float:
return 3 * (x ** 2) - 2


Expand Down