Skip to content

Python Program to Check Krishnamurthy Number #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 29, 2020
Merged

Python Program to Check Krishnamurthy Number #2248

merged 19 commits into from
Jul 29, 2020

Conversation

Utsav1999
Copy link
Contributor

Describe your change:

Added Python Program to check whether a number is Krishnamurthy Number or not.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Utsav1999 Utsav1999 changed the title Utsav python Python Program to Check Krishnamurthy Number Jul 28, 2020
@TravisBuddy
Copy link

Hey @Utsav1999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 065cd510-d0fa-11ea-b8d2-e37d5f97d09d

@TravisBuddy
Copy link

Hey @Utsav1999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8ef1a030-d0fb-11ea-b8d2-e37d5f97d09d

@TravisBuddy
Copy link

Hey @Utsav1999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e898c210-d0fd-11ea-b8d2-e37d5f97d09d

cclauss
cclauss reviewed Jul 28, 2020
View reviewed changes
cclauss
cclauss reviewed Jul 28, 2020
View reviewed changes
cclauss
cclauss reviewed Jul 28, 2020
View reviewed changes
cclauss
cclauss reviewed Jul 28, 2020
View reviewed changes
cclauss
cclauss reviewed Jul 28, 2020
View reviewed changes
cclauss
cclauss reviewed Jul 28, 2020
View reviewed changes
cclauss
cclauss reviewed Jul 28, 2020
View reviewed changes
@Utsav1999
Copy link
Contributor Author

@cclauss can you please resolve the conflict?

@TravisBuddy
Copy link

Hey @Utsav1999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e165db80-d171-11ea-bb2f-e1a2ee6530fc

@TravisBuddy
Copy link

Hey @Utsav1999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 38cba370-d175-11ea-bb2f-e1a2ee6530fc

@TravisBuddy
Copy link

Travis tests have failed

Hey @Utsav1999,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: cbbd7a40-d176-11ea-bb2f-e1a2ee6530fc

@Utsav1999
Copy link
Contributor Author

Why it is giving doctest failure at line 21 for factorial(5)?

@cclauss
Copy link
Member

cclauss commented Jul 29, 2020

Because doctests are extremely literal.

@cclauss cclauss merged commit c7a5f16 into TheAlgorithms:master Jul 29, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Utsav1999 @cclauss @stokhos
Python Program to Check Krishnamurthy Number (TheAlgorithms#2248)
e25ed92 
* Added Python Program to Check Perfet Number

* CodeSpell Error Fix - 1

* Build Error Fix - 1

* Made suggested changes

* Use generator expression

* Added Python Program to Check Krishnamurthy Number or not

* Added Python Program to Check Krishnamurthy Number

* Added Python Program to Check Krishnamurthy Number or not

* Build Error Fix - 1

* Build Error Fix - 2

* Fix Brackets positions

* Fix Character Exceeding Error

* Made Review Changes

* Build Error Fix - 3

* Build Error Fix - 4

* Update krishnamurthy_number.py

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Utsav1999 @TravisBuddy @cclauss