Skip to content

Added Python Program to Check Perfect Number #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2020
Merged

Added Python Program to Check Perfect Number #2244

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc21ea1
Added Python Program to Check Perfet Number
Utsav1999 Jul 27, 2020
fb23a6c
CodeSpell Error Fix - 1
Utsav1999 Jul 27, 2020
0c6adf1
Build Error Fix - 1
Utsav1999 Jul 28, 2020
b0e9317
Made suggested changes
Utsav1999 Jul 28, 2020
c02b24e
Use generator expression
cclauss Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions maths/perfect_number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
"""
== Perfect Number ==
In number theory, a perfect number is a
positive integer that is equal to the sum
of its positive divisors, excluding the
number itself.
>>> For 6 ==> divisors[1, 2, 3, 6]
Excluding 6 sum(divisors) = 1 + 2 + 3 = 6
So, 6 is a Perfect Number
Other examples of Perfect Numbers: 28, 486, ...

"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""
== Perfect Number ==
In number theory, a perfect number is a
positive integer that is equal to the sum
of its positive divisors, excluding the
number itself.
>>> For 6 ==> divisors[1, 2, 3, 6]
Excluding 6 sum(divisors) = 1 + 2 + 3 = 6
So, 6 is a Perfect Number
Other examples of Perfect Numbers: 28, 486, ...
"""
"""
== Perfect Number ==
In number theory, a perfect number is a positive integer that is equal to the sum of
its positive divisors, excluding the number itself.
For 6 ==> divisors[1, 2, 3, 6]
Excluding 6, the sum(divisors) is 1 + 2 + 3 = 6
So, 6 is a Perfect Number
Other examples of Perfect Numbers: 28, 486, ...
https://en.wikipedia.org/wiki/Perfect_number
"""



def perfect(number: int) -> bool:
divisors = []
for i in range(1, ((number // 2) + 1)):
"""
starting from 1 as division by 0
will raise error.
A number at most can be divisible
by the half of the number except
the number itself
>>> 6 at most can be divisible by 3
except 6 itself
"""

if (number % i) == 0:
divisors.append(i)

if sum(divisors) == number:
return True
else:
return False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put all of this on one line using a Python list comprehension.

Doctests chould be:

"""
>>> perfect(27)
False
>>> perfect(28)
True
>>> perfect(29)
False
"""

The content to the right of >>> must be valid Python code that will be run by the test harness. This explains why the Travis CI tests are currently failing.



if __name__ == "__main__":
print("Program to check whether a number is a Perfect number or not.......")
number = int(input("Enter number: "))
check = perfect(number)
if check:
print("{} is a Perfect Number.".format(number))
else:
print("{} is not a Perfect Number.".format(number))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
check = perfect(number)
if check:
print("{} is a Perfect Number.".format(number))
else:
print("{} is not a Perfect Number.".format(number))
print(f"{number} is a {'' if perfect(number) else 'not '}Perfect Number.")