-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Karger's Algorithm #2237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Karger's Algorithm #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @lol-cubes, TravisCI finished with status TravisBuddy Request Identifier: 7eb40710-cec8-11ea-84f0-41e93e5606ac |
Please unsubscribe me from all future emails.
…On Sat, Jul 25, 2020, 5:47 PM Arin Khare ***@***.***> wrote:
*Describe your change:*
I added an implementation of Karger's algorithm for partitioning a graph,
as described here:
https://en.wikipedia.org/wiki/Karger%27s_algorithm
- Add an algorithm?
- Fix a bug or typo in an existing algorithm?
- Documentation change?
*Checklist:*
- I have read CONTRIBUTING.md
<https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md>.
- This pull request is all my own work -- I have not plagiarized.
- I know that pull requests will not be merged if they fail the
automated tests.
- This PR only changes one algorithm file. To ease review, please open
separate PRs for separate algorithms.
- All new Python files are placed inside an existing directory.
- All filenames are in all lowercase characters with no spaces or
dashes.
- All functions and variable names follow Python naming conventions.
- All function parameters and return values are annotated with Python type
hints <https://docs.python.org/3/library/typing.html>.
- All functions have doctests
<https://docs.python.org/3/library/doctest.html> that pass the
automated testing.
- All new algorithms have a URL in its comments that points to
Wikipedia or other similar explanation.
- If this pull request resolves one or more open issues then the
commit message contains Fixes: #{$ISSUE_NO}.
(It doesn't solve any issues)
------------------------------
You can view, comment on, or merge this pull request online at:
#2237
Commit Summary
- Add implementation of Karger's Algorithm
- Remove print statement from karger's algorithm function
File Changes
- *A* graphs/karger.py
<https://github.com/TheAlgorithms/Python/pull/2237/files#diff-6d5bc9a2836c9812345d84370d09e254>
(86)
Patch Links:
- https://github.com/TheAlgorithms/Python/pull/2237.patch
- https://github.com/TheAlgorithms/Python/pull/2237.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2237>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQFRFCTNGQOJVN5QIGUEE53R5NOHLANCNFSM4PHVMRZQ>
.
|
cclauss
reviewed
Jul 26, 2020
cclauss
approved these changes
Jul 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Add implementation of Karger's Algorithm * Remove print statement from karger's algorithm function * Fix style issues in graphs/karger.py * Change for loops to set comprehensions where appropriate in graphs/karger.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
I added an implementation of Karger's algorithm for partitioning a graph, as described here:
https://en.wikipedia.org/wiki/Karger%27s_algorithm
Checklist:
Fixes: #{$ISSUE_NO}
.(It doesn't solve any issues)