Skip to content

remove function overhead #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2020
Merged

remove function overhead #2233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f83bc52
remove function overhead
lance-pyles Jul 23, 2020
1adda53
remove unused import
lance-pyles Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions maths/area.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
Find the area of various geometric shapes
"""
from math import pi
from typing import Union


def surface_area_cube(side_length: Union[int, float]) -> float:
def surface_area_cube(side_length: float) -> float:
"""
Calculate the Surface Area of a Cube.

Expand All @@ -14,7 +13,7 @@ def surface_area_cube(side_length: Union[int, float]) -> float:
>>> surface_area_cube(3)
54
"""
return 6 * pow(side_length, 2)
return 6 * side_length ** 2
Copy link
Member

@cclauss cclauss Jul 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to bounce back and forth every 48 hours? #2223 (review) ;-)



def surface_area_sphere(radius: float) -> float:
Expand All @@ -28,10 +27,10 @@ def surface_area_sphere(radius: float) -> float:
>>> surface_area_sphere(1)
12.566370614359172
"""
return 4 * pi * pow(radius, 2)
return 4 * pi * radius ** 2


def area_rectangle(length, width):
def area_rectangle(length: float, width: float) -> float:
"""
Calculate the area of a rectangle

Expand All @@ -41,17 +40,17 @@ def area_rectangle(length, width):
return length * width


def area_square(side_length):
def area_square(side_length: float) -> float:
"""
Calculate the area of a square

>>> area_square(10)
100
"""
return pow(side_length, 2)
return side_length ** 2


def area_triangle(base, height):
def area_triangle(base: float, height: float) -> float:
"""
Calculate the area of a triangle

Expand All @@ -61,7 +60,7 @@ def area_triangle(base, height):
return (base * height) / 2


def area_parallelogram(base, height):
def area_parallelogram(base: float, height: float) -> float:
"""
Calculate the area of a parallelogram

Expand All @@ -71,7 +70,7 @@ def area_parallelogram(base, height):
return base * height


def area_trapezium(base1, base2, height):
def area_trapezium(base1: float, base2: float, height: float) -> float:
"""
Calculate the area of a trapezium

Expand All @@ -81,14 +80,14 @@ def area_trapezium(base1, base2, height):
return 1 / 2 * (base1 + base2) * height


def area_circle(radius):
def area_circle(radius: float) -> float:
"""
Calculate the area of a circle

>>> area_circle(20)
1256.6370614359173
"""
return pi * pow(radius, 2)
return pi * radius ** 2


def main():
Expand Down