Skip to content

added a faster solution to project euler problem 14 #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

crazazy
Copy link

@crazazy crazazy commented Jul 19, 2020

Describe your change:

Adds a new algorithm for project euler problem 14. This algorithm is quite a bit faster than the 2 existing algorithms, as it avoids computing the same collatz chain twice

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @crazazy,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 24d1cf70-c9cd-11ea-994d-63e86313f42e

@TravisBuddy
Copy link

Hey @crazazy,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d52a9dc0-c9cd-11ea-994d-63e86313f42e

Copy link
Member

@ruppysuppy ruppysuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use nested functions, move the functions out of the solution function body. Add type hints to all functions and doctests too

crazazy added 4 commits July 20, 2020 22:19
I am not sure it the calculate_chain doctest works, since they are
testing the side effects of the function, we will see what CI thinks of
it
noone gave a good reason on why to remove it, and since this file is
executable anyway (and thus easier to run for me)
@TravisBuddy
Copy link

Travis tests have failed

Hey @crazazy,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 811b5c80-caca-11ea-84bb-258f0278865c

doctests reset the environment after each function evaluation, so we
can't use doctests to inspect side effects of void functions
@crazazy
Copy link
Author

crazazy commented Jul 20, 2020

Added docstrings on all helper functions and doctests wherever possible. Sadly, it turns out that I can't view the side effects on calculate_chain, so that function cannot have doctests

@stale
Copy link

stale bot commented Aug 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Aug 21, 2020
@stale
Copy link

stale bot commented Aug 28, 2020

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used to mark an issue or pull request stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants