-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
added a faster solution to project euler problem 14 #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @crazazy, TravisCI finished with status TravisBuddy Request Identifier: 24d1cf70-c9cd-11ea-994d-63e86313f42e |
Hey @crazazy, TravisCI finished with status TravisBuddy Request Identifier: d52a9dc0-c9cd-11ea-994d-63e86313f42e |
It's been a while since I worked with typed python, forgive me ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use nested functions, move the functions out of the solution function body. Add type hints to all functions and doctests too
I am not sure it the calculate_chain doctest works, since they are testing the side effects of the function, we will see what CI thinks of it
noone gave a good reason on why to remove it, and since this file is executable anyway (and thus easier to run for me)
Travis tests have failedHey @crazazy, TravisBuddy Request Identifier: 811b5c80-caca-11ea-84bb-258f0278865c |
doctests reset the environment after each function evaluation, so we can't use doctests to inspect side effects of void functions
Added docstrings on all helper functions and doctests wherever possible. Sadly, it turns out that I can't view the side effects on calculate_chain, so that function cannot have doctests |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions. |
Describe your change:
Adds a new algorithm for project euler problem 14. This algorithm is quite a bit faster than the 2 existing algorithms, as it avoids computing the same collatz chain twice
Checklist:
Fixes: #{$ISSUE_NO}
.