Skip to content

Errors notifications under pull requests #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2020
Merged

Errors notifications under pull requests #2081

merged 2 commits into from
Jun 8, 2020

Conversation

l3str4nge
Copy link
Member

Describe your change:

Added TravisBuddy (https://github.com/bluzi/travis-buddy) and github action (https://github.com/plettich/python_codespell_action) to get information about errors under comments.
Hope it helps with #1910 😃

Tested on my forked repo: l3str4nge#3

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@l3str4nge l3str4nge requested review from cclauss and poyea June 8, 2020 08:50
@TravisBuddy
Copy link

Hey @mateuszz0000,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3955bce0-a966-11ea-9161-4f77e253115e

cclauss
cclauss approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!!

@cclauss cclauss merged commit 1e7df7f into TheAlgorithms:master Jun 8, 2020
@poyea
Copy link
Member

poyea commented Jun 8, 2020

This is so good!

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@l3str4nge @stokhos
Errors notifications under pull requests (TheAlgorithms#2081)
e805ae7 
* Added error comments under pull requests

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@poyea poyea Awaiting requested review from poyea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l3str4nge @TravisBuddy @poyea @cclauss