Added doctests to bucket sort #2079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Jun 16, 2020
sorts/bucket_sort.py
Outdated
| number of buckets. | ||
|
|
||
| Time Complexity of Solution: | ||
| Worst case scenario occurs when all the elements are placed in a single bucket. The overall performance |
There was a problem hiding this comment.
Please wrap lines to 88 characters max.
Travis tests have failedHey @mateuszz0000, TravisBuddy Request Identifier: 75775280-af9a-11ea-aad4-a340821c2822 |
|
What is it |
|
Is it a problem that the algorithm uses the builtin |
|
@cclauss should we merge it? |
cclauss
reviewed
Jun 17, 2020
sorts/bucket_sort.py
Outdated
| @@ -1,5 +1,3 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Why remove the shebang line? https://en.wikipedia.org/wiki/Shebang_(Unix)
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added doctests to bucket sort * Missing typehint * Wrap long lines * updating DIRECTORY.md * Update bucket_sort.py * updating DIRECTORY.md * Update bucket_sort.py Co-authored-by: Christian Clauss <[email protected]> Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added missing doctests.
Checklist:
Fixes: #{$ISSUE_NO}.