Skip to content

Fix doubly linked list algorithm #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 2, 2020
Merged

Fix doubly linked list algorithm #2062

merged 4 commits into from
Aug 2, 2020

Conversation

TheSuperNoob
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TheSuperNoob
Copy link
Contributor Author

This also includes adding the doctests from #2052

@TheSuperNoob
Fix bug with insert_at_tail method
cefc034 
Create __str__() method for Node class and LinkedList class
@TheSuperNoob
Simplify __str__() of LinkedList
c6d1b1a 
Returns empty string if there are no elements in the list
@stale
Copy link

stale bot commented Jul 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Jul 24, 2020
@stale
Copy link

stale bot commented Jul 31, 2020

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.

@stale stale bot closed this Jul 31, 2020
@poyea poyea reopened this Jul 31, 2020
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Jul 31, 2020
@poyea poyea self-assigned this Jul 31, 2020
poyea
poyea approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to the commenters. And 10*thank you for your pull request!🤩

@TravisBuddy
Copy link

Hey @TheSuperNoob,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2ecb6580-d42d-11ea-9b7b-6b7bbdba586d

@poyea poyea merged commit b2e8672 into TheAlgorithms:master Aug 2, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@TheSuperNoob @stokhos
Fix doubly linked list algorithm (TheAlgorithms#2062)
89d0bfb 
* Fix doubly linked list algorithm

* Fix bug with insert_at_tail method

Create __str__() method for Node class and LinkedList class

* Simplify __str__() of LinkedList

Returns empty string if there are no elements in the list

* Fix description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@mquevill mquevill mquevill requested changes

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheSuperNoob @TravisBuddy @cclauss @mquevill @poyea