Easter date gauss algorithm #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
May 19, 2020
other/gauss_easter.py
Outdated
Comment on lines
24
to
33
| a = year % 19 | ||
| b = year % 4 | ||
| c = year % 7 | ||
| k = math.floor(year / 100) | ||
| p = math.floor((13 + 8 * k) / 25) | ||
| q = k / 4 | ||
| M = (15 - p + k - q) % 30 | ||
| N = (4 + k - q) % 7 | ||
| d = (19 * a + M) % 30 | ||
| e = (2 * b + 4 * c + 6 * d + N) % 7 |
There was a problem hiding this comment.
Single letter variable names are old school and they force the reader to guess a lot to make sense of this algorithm.
cclauss
reviewed
May 19, 2020
other/gauss_easter.py
Outdated
Comment on lines
44
to
48
| print(f"Easter in 2023 will be {gauss_easter(2023)}") | ||
| print(f"Easter in 2021 will be {gauss_easter(2021)}") | ||
| print(f"Easter in 2010 was {gauss_easter(2010)}") | ||
| print(f"Easter in 1994 was {gauss_easter(1994)}") | ||
| print(f"Easter in 2000 was {gauss_easter(2000)}") |
There was a problem hiding this comment.
Suggested change
| print(f"Easter in 2023 will be {gauss_easter(2023)}") | |
| print(f"Easter in 2021 will be {gauss_easter(2021)}") | |
| print(f"Easter in 2010 was {gauss_easter(2010)}") | |
| print(f"Easter in 1994 was {gauss_easter(1994)}") | |
| print(f"Easter in 2000 was {gauss_easter(2000)}") | |
| for year in (1994, 2000, 2010, 2021, 2023): | |
| tense = "will be" if year > datetime.now().year else "was" | |
| print(f"Easter in {year} {tense} {gauss_easter(year)}") |
cclauss
approved these changes
May 19, 2020
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added gauss easter algorithm * Fixes in easter algorithm * Commit suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added Gauss algorithm to calculate easter date for given year. Source: https://en.wikipedia.org/wiki/Computus#Gauss'_Easter_algorithm
Checklist:
Fixes: #{$ISSUE_NO}.