-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
Update basic_graphs.py #1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update basic_graphs.py #1990
Conversation
missing return statement line no:223.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. Why would this return a sum
? Prim's algorithm should return a tree.
Also, this file has some other issues - no tests or references for algorithms. You may consider fixing some of those for functions in this file.
@poyea is this seems ok |
@poyea Please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!🤩
@karthikeyansa @cclauss @itsvinayak I think we can add some test graphs to this file, as it is quite difficult to see the expected output. An input graph for
However, |
* Update basic_graphs.py missing return statement line no:223. * Update basic_graphs.py Co-authored-by: vinayak <[email protected]>
missing return statement line no:223.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}
.