Skip to content

Add type hints to max_heap.py #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 11, 2020
Merged

Add type hints to max_heap.py #1960

merged 6 commits into from
May 11, 2020

Conversation

halilylm
Copy link
Contributor

@halilylm halilylm commented May 8, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
    Binary max heap implementation

@cclauss cclauss changed the title Max heap implementation Add type hints to max_heap.py May 10, 2020
@halilylm halilylm requested a review from cclauss May 10, 2020 15:16
@cclauss cclauss merged commit 1151d8b into TheAlgorithms:master May 11, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@halilylm @cclauss @stokhos
Add type hints to max_heap.py (TheAlgorithms#1960)
cba60ae 
* Max heap implementation

* Update max_heap.py

* Update max_heap.py

* Update max_heap.py

* __len__ method added

* Update max_heap.py

Co-authored-by: halilpython <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@theroyakash theroyakash theroyakash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halilylm @cclauss @theroyakash