Skip to content

Update fast_fibonacci.py #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2020
Merged

Update fast_fibonacci.py #1889

merged 2 commits into from
May 19, 2020

Conversation

SandersLin
Copy link
Contributor

@SandersLin SandersLin commented Apr 17, 2020 •
edited
Loading

Describe your change:

added type hints.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Apr 17, 2020
View reviewed changes
dynamic_programming/fast_fibonacci.py Outdated
@@ -8,14 +8,14 @@


# returns F(n)
def fibonacci(n: int): # noqa: E999 This syntax is Python 3 only
def fibonacci(n: int) -> int: # noqa: E999 This syntax is Python 3 only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lose the noqa comments here and below because Python 2 is dead.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As encouraged in the Coding Style section of CONTRIBUTING.md

Please write in Python 3.7+

So I agree with @cclauss comment.

@stale
Copy link

stale bot commented May 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label May 19, 2020
@stale stale bot removed the stale Used to mark an issue or pull request stale. label May 19, 2020
@cclauss cclauss merged commit 777ddca into TheAlgorithms:master May 19, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@SandersLin @cclauss @stokhos
Update fast_fibonacci.py (TheAlgorithms#1889)
2563421 
* Update fast_fibonacci.py

* Update fast_fibonacci.py

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolmn hugolmn hugolmn left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SandersLin @cclauss @hugolmn